ZOOKEEPER-4784: Token based ASF JIRA authentication #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I71203b7c02d4e25ce47c11eea859c372ed0c18b6
anmolnar
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Great stuff, thanks @szucsvillo !
I'll try it on a real patch soon.
anmolnar
requested changes
Feb 9, 2024
There was a problem hiding this comment.
Got the following error message when merging #2100
Would you like to update an associated JIRA? (y/n): y
Traceback (most recent call last):
File "zk-merge-pr.py", line 528, in <module>
main()
File "zk-merge-pr.py", line 514, in main
resolve_jira_issues(commit_title, merged_refs, jira_comment)
File "zk-merge-pr.py", line 321, in resolve_jira_issues
resolve_jira_issue(merge_branches, comment, jira_id)
File "zk-merge-pr.py", line 260, in resolve_jira_issue
asf_jira = jira.client.JIRA(jira_server, token_auth=JIRA_ACCESS_TOKEN)
TypeError: __init__() got an unexpected keyword argument 'token_auth'
Please check.
anmolnar
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Works fine now. I had to upgrade python-jira to 3.6.0. This should be noted on the wiki page later.
Thanks @szucsvillo !
AlphaCanisMajoris
pushed a commit
to AlphaCanisMajoris/zookeeper
that referenced
this pull request
Mar 28, 2024
Reviewers: anmolnar, anmolnar Author: szucsvillo Closes apache#2106 from szucsvillo/ZOOKEEPER-4784
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.