ZOOKEEPER-2332: Fix server failed to start for empty txn log #2141
+95
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new txn log is created, it encounters a failure before writing to the file header. The txn log file is empty at this moment, the server starts up again, reads the file, and fails to load the database because the header is not recognized. The patch detects that the empty txn log is at the end of the database, and if the file is empty, it deletes the file and prompts the server to reboot to reload it. When one of the txn logs in the middle of the database is empty, it will refuse to start up since it's a real corruption.
fanyang89
force-pushed
the
ZOOKEEPER-2332
branch
from
a33d3bb
to
2a515d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new txn log is created, it encounters a failure before writing to the file header. The txn log file is empty at this moment, the server starts up again, reads the file, and fails to load the database because the header is not recognized.
The patch detects that the empty txn log is at the end of the database, and if the file is empty, it deletes the file and prompts the server to reboot to reload it.
When one of the txn logs in the middle of the database is empty, it will refuse to start up since it's a real corruption.