[ZOOKEEPER-4834] fix typos in Apache ZooKeeper #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
reviewed
May 27, 2024
Signed-off-by: ZhangJian He <shoothzj@gmail.com>
tisonkun
reviewed
May 29, 2024
zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatchManagerOptimized.java
Outdated
Show resolved
Hide resolved
tisonkun
reviewed
May 29, 2024
| @@ -51,14 +51,14 @@ public class SnapStream { | |||
|
|
|||
| private static final Logger LOG = LoggerFactory.getLogger(SnapStream.class); | |||
|
|
|||
| public static final String ZOOKEEPER_SHAPSHOT_STREAM_MODE = "zookeeper.snapshot.compression.method"; | |||
| public static final String ZOOKEEPER_SNAPSHOT_STREAM_MODE = "zookeeper.snapshot.compression.method"; | |||
tisonkun
reviewed
May 29, 2024
Signed-off-by: ZhangJian He <shoothzj@gmail.com>
|
@tisonkun Thanks for your review. I think we can discuss later in another thread to decide public API changes(not in this PR), I revert it fisrt and add in |
kezhuw
reviewed
Jun 12, 2024
...ector/src/main/java/org/apache/zookeeper/inspector/gui/nodeviewer/NodeSelectionListener.java
Outdated
Show resolved
Hide resolved
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java
Outdated
Show resolved
Hide resolved
zookeeper-server/src/test/java/org/apache/zookeeper/test/GetProposalFromTxnTest.java
Show resolved
Hide resolved
zookeeper-server/src/test/java/org/apache/zookeeper/test/QuorumUtilTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: ZhangJian He <shoothzj@gmail.com>
|
@kezhuw Thanks for your thorough review. I have address your comments.
|
kezhuw
approved these changes
Jun 13, 2024
|
@eolivelli @maoling PTAL, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://lists.apache.org/thread/bfxpbwscprkcyvlt64t4oyf4zr1g3dt7