Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-2744: Typos in the comments of ZooKeeper class #217

Closed
wants to merge 1 commit into from
Closed

ZOOKEEPER-2744: Typos in the comments of ZooKeeper class #217

wants to merge 1 commit into from

Conversation

afine
Copy link
Contributor

@afine afine commented Apr 6, 2017

No description provided.

eribeiro
eribeiro reviewed Apr 6, 2017
View reviewed changes
Copy link
Contributor

@eribeiro eribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@eribeiro
Copy link
Contributor

eribeiro commented Apr 6, 2017

@afine it would be possible to cherry pick this commit to branch-3.4, if it also has those typos?

@afine
Copy link
Contributor Author

afine commented Apr 7, 2017

@eribeiro Agreed. Please see #219

@asfgit asfgit closed this in a43b982 Apr 18, 2017
asfgit pushed a commit that referenced this pull request Apr 18, 2017
@afine @hanm
ZOOKEEPER-2744: Typos in the comments of ZooKeeper class
0665cb7 
Author: Abraham Fine <afine@apache.org>

Reviewers: Michael Han <hanm@apache.org>, Edward Ribeiro <edward.ribeiro@gmail.com>

Closes #217 from afine/ZOOKEEPER-2744
lvfangmin pushed a commit to lvfangmin/zookeeper that referenced this pull request Jun 17, 2018
@afine
ZOOKEEPER-2744: Typos in the comments of ZooKeeper class
5a5fd6a 
Author: Abraham Fine <afine@apache.org>

Reviewers: Michael Han <hanm@apache.org>, Edward Ribeiro <edward.ribeiro@gmail.com>

Closes apache#217 from afine/ZOOKEEPER-2744

(cherry picked from commit 0665cb7)
Signed-off-by: Michael Han <hanm@apache.org>
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
@afine @RokLenarcic
ZOOKEEPER-2744: Typos in the comments of ZooKeeper class
b796355 
Author: Abraham Fine <afine@apache.org>

Reviewers: Michael Han <hanm@apache.org>, Edward Ribeiro <edward.ribeiro@gmail.com>

Closes apache#217 from afine/ZOOKEEPER-2744

(cherry picked from commit 0665cb7)
Signed-off-by: Michael Han <hanm@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eribeiro eribeiro eribeiro left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@afine @eribeiro