ZOOKEEPER-2316: comment does not match code logic #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanm
reviewed
Apr 24, 2017
| @@ -724,6 +724,8 @@ synchronized public boolean tryToCommit(Proposal p, long zxid, SocketAddress fol | |||
| // concurrent reconfigs are allowed, this can happen. | |||
| if (outstandingProposals.containsKey(zxid - 1)) return false; | |||
|
|
|||
| // in order to be committed, a proposal must be accepted by a quorum | |||
| // | |||
There was a problem hiding this comment.
This blank line can be removed.
There was a problem hiding this comment.
@hanm I think the blank line may be fine, it provides separation from the idea on the next line so it doesn't read as a single sentence.
There was a problem hiding this comment.
I would just use a period to do the separation.
asfgit
pushed a commit
that referenced
this pull request
Apr 27, 2017
Fixing ZOOKEEPER-2316. Author: Umesh Panchaksharaiah <upangit@users.noreply.github.com> Author: Umesh Panchaksharaiah <upanchak@yahoo.com> Reviewers: Abraham Fine <afine@apache.org>, Michael Han <hanm@apache.org> Closes #223 from upangit/ZOOKEEPER-2316 and squashes the following commits: 7669f19 [Umesh Panchaksharaiah] ZOOKEEPER-2316: comment does not match code logic 7705e24 [Umesh Panchaksharaiah] ZOOKEEPER-2316: comment does not match code logic (cherry picked from commit f7281f3) Signed-off-by: Michael Han <hanm@apache.org>
lvfangmin
pushed a commit
to lvfangmin/zookeeper
that referenced
this pull request
Jun 17, 2018
Fixing ZOOKEEPER-2316. Author: Umesh Panchaksharaiah <upangit@users.noreply.github.com> Author: Umesh Panchaksharaiah <upanchak@yahoo.com> Reviewers: Abraham Fine <afine@apache.org>, Michael Han <hanm@apache.org> Closes apache#223 from upangit/ZOOKEEPER-2316 and squashes the following commits: 7669f19 [Umesh Panchaksharaiah] ZOOKEEPER-2316: comment does not match code logic 7705e24 [Umesh Panchaksharaiah] ZOOKEEPER-2316: comment does not match code logic
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
Fixing ZOOKEEPER-2316. Author: Umesh Panchaksharaiah <upangit@users.noreply.github.com> Author: Umesh Panchaksharaiah <upanchak@yahoo.com> Reviewers: Abraham Fine <afine@apache.org>, Michael Han <hanm@apache.org> Closes apache#223 from upangit/ZOOKEEPER-2316 and squashes the following commits: 7669f19 [Umesh Panchaksharaiah] ZOOKEEPER-2316: comment does not match code logic 7705e24 [Umesh Panchaksharaiah] ZOOKEEPER-2316: comment does not match code logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing ZOOKEEPER-2316.