ZOOKEEPER-2249: CRC check failed when preAllocSize smaller than node data #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afine
force-pushed
the
ZOOKEEPER-2249
branch
from
fc03120
to
44ad057
Compare
afine
changed the title
phunt
reviewed
Dec 20, 2017
| @@ -211,7 +211,7 @@ public static long padLogFile(FileOutputStream f,long currentSize, | |||
| long preAllocSize) throws IOException{ | |||
| long position = f.getChannel().position(); | |||
| if (position + 4096 >= currentSize) { | |||
| currentSize = currentSize + preAllocSize; | |||
| currentSize = position + preAllocSize; | |||
There was a problem hiding this comment.
Nice catch Abe! This looks like a reasonable fix, however it results in the doc'd invariant not being followed
"allocates space in the transaction log file in blocks of preAllocSize kilobytes"
I believe in this case you want something which will maintain the file as a multiple of this value.
Perhaps a while loop inside the conditional, replacing "currentSize = currentSize + preAllocSize;" with:
while (position + 4096 >= currentSize) {
currentSize = currentSize + preAllocSize
}
afine
force-pushed
the
ZOOKEEPER-2249
branch
2 times, most recently
from
a97392b
to
e57676f
Compare
afine
force-pushed
the
ZOOKEEPER-2249
branch
from
e57676f
to
f3bc06c
Compare
asfgit
pushed a commit
that referenced
this pull request
Jan 18, 2018
…data This bug is caused by an issue in our file padding logic. We calculate an incorrect position to add padding when appending to the transaction log, this often corrupts a transaction. When the log is read the CRC check will correctly fail. Author: Abraham Fine <afine@apache.org> Reviewers: phunt@apache.org Closes #436 from afine/ZOOKEEPER-2249 and squashes the following commits: f3bc06c [Abraham Fine] Improve testing and respond to phunt's comment 44ad057 [Abraham Fine] ZOOKEEPER-2249: CRC check failed when preAllocSize smaller than node data Change-Id: Id8ba9ad730760cb78672127b8c0e02db60b4e87d (cherry picked from commit 4d629d2) Signed-off-by: Patrick Hunt <phunt@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Jan 18, 2018
…data This bug is caused by an issue in our file padding logic. We calculate an incorrect position to add padding when appending to the transaction log, this often corrupts a transaction. When the log is read the CRC check will correctly fail. Author: Abraham Fine <afine@apache.org> Reviewers: phunt@apache.org Closes #436 from afine/ZOOKEEPER-2249 and squashes the following commits: f3bc06c [Abraham Fine] Improve testing and respond to phunt's comment 44ad057 [Abraham Fine] ZOOKEEPER-2249: CRC check failed when preAllocSize smaller than node data Change-Id: Id8ba9ad730760cb78672127b8c0e02db60b4e87d (cherry picked from commit 4d629d2) Signed-off-by: Patrick Hunt <phunt@apache.org>
|
LGTM +1. Thanks @afine . Committed to 3.4/3.5/trunk. |
maoling
pushed a commit
to maoling/zookeeper
that referenced
this pull request
Jan 26, 2018
…data This bug is caused by an issue in our file padding logic. We calculate an incorrect position to add padding when appending to the transaction log, this often corrupts a transaction. When the log is read the CRC check will correctly fail. Author: Abraham Fine <afine@apache.org> Reviewers: phunt@apache.org Closes apache#436 from afine/ZOOKEEPER-2249 and squashes the following commits: f3bc06c [Abraham Fine] Improve testing and respond to phunt's comment 44ad057 [Abraham Fine] ZOOKEEPER-2249: CRC check failed when preAllocSize smaller than node data Change-Id: Id8ba9ad730760cb78672127b8c0e02db60b4e87d
lvfangmin
pushed a commit
to lvfangmin/zookeeper
that referenced
this pull request
Jun 17, 2018
…data This bug is caused by an issue in our file padding logic. We calculate an incorrect position to add padding when appending to the transaction log, this often corrupts a transaction. When the log is read the CRC check will correctly fail. Author: Abraham Fine <afine@apache.org> Reviewers: phunt@apache.org Closes apache#436 from afine/ZOOKEEPER-2249 and squashes the following commits: f3bc06c [Abraham Fine] Improve testing and respond to phunt's comment 44ad057 [Abraham Fine] ZOOKEEPER-2249: CRC check failed when preAllocSize smaller than node data Change-Id: Id8ba9ad730760cb78672127b8c0e02db60b4e87d
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
…data This bug is caused by an issue in our file padding logic. We calculate an incorrect position to add padding when appending to the transaction log, this often corrupts a transaction. When the log is read the CRC check will correctly fail. Author: Abraham Fine <afine@apache.org> Reviewers: phunt@apache.org Closes apache#436 from afine/ZOOKEEPER-2249 and squashes the following commits: f3bc06c [Abraham Fine] Improve testing and respond to phunt's comment 44ad057 [Abraham Fine] ZOOKEEPER-2249: CRC check failed when preAllocSize smaller than node data Change-Id: Id8ba9ad730760cb78672127b8c0e02db60b4e87d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is caused by an issue in our file padding logic. We calculate an incorrect position to add padding when appending to the transaction log, this often corrupts a transaction. When the log is read the CRC check will correctly fail.