ZOOKEEPER-3002 upgrade to jdk 8 #502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanm
suggested changes
Apr 16, 2018
hanm
approved these changes
Apr 17, 2018
asfgit
pushed a commit
that referenced
this pull request
Apr 17, 2018
Set minimum requirement to java 1.8 The code successfully compiled with 8.0.161-oracle and 8.0.163-zulu. Checking the generated class file it reports 1.8 as version: javap -verbose build/classes/org/apache/zookeeper/server/ServerStats.class | grep version minor version: 0 major version: 52 Author: Norbert Kalmar <nkalmar@yahoo.com> Reviewers: Andor Molnár <andor@cloudera.com>, Michael Han <hanm@apache.org> Closes #502 from nkalmar/ZOOKEEPER-3002_java1.8 (cherry picked from commit 519db3f) Signed-off-by: Michael Han <hanm@apache.org>
lvfangmin
pushed a commit
to lvfangmin/zookeeper
that referenced
this pull request
Jun 17, 2018
Set minimum requirement to java 1.8 The code successfully compiled with 8.0.161-oracle and 8.0.163-zulu. Checking the generated class file it reports 1.8 as version: javap -verbose build/classes/org/apache/zookeeper/server/ServerStats.class | grep version minor version: 0 major version: 52 Author: Norbert Kalmar <nkalmar@yahoo.com> Reviewers: Andor Molnár <andor@cloudera.com>, Michael Han <hanm@apache.org> Closes apache#502 from nkalmar/ZOOKEEPER-3002_java1.8
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
Set minimum requirement to java 1.8 The code successfully compiled with 8.0.161-oracle and 8.0.163-zulu. Checking the generated class file it reports 1.8 as version: javap -verbose build/classes/org/apache/zookeeper/server/ServerStats.class | grep version minor version: 0 major version: 52 Author: Norbert Kalmar <nkalmar@yahoo.com> Reviewers: Andor Molnár <andor@cloudera.com>, Michael Han <hanm@apache.org> Closes apache#502 from nkalmar/ZOOKEEPER-3002_java1.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set minimum requirement to java 1.8
The code successfully compiled with 8.0.161-oracle and 8.0.163-zulu.
Checking the generated class file it reports 1.8 as version:
javap -verbose build/classes/org/apache/zookeeper/server/ServerStats.class | grep version
minor version: 0
major version: 52