ZOOKEEPER-3019 add metric for slow fsyncs count #510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkalmar
force-pushed
the
branch-3.4
branch
2 times, most recently
from
d240f39
to
b976a03
Compare
lvfangmin
reviewed
Jun 4, 2018
| if(serverStats != null) { | ||
| serverStats.incrementFsyncThresholdExceedCount(); | ||
| } else { | ||
| LOG.warn("fsyncWarningThresholdMS exceeded, but serverStats not added in FileTxnLog!"); |
There was a problem hiding this comment.
This log seems redundant to me, we can tell the fsync threshold exceeded from the log at line 340, and serverStats is set, we know there will be stats in serverStats, otherwise we know it's not set.
There was a problem hiding this comment.
Okay, sounds fair. I will remove it.
Thanks for pointing this out!
asfgit
pushed a commit
that referenced
this pull request
Jun 8, 2018
Backported fsync metric count from master. Author: Norbert Kalmar <nkalmar@yahoo.com> Reviewers: Andor Molnar <andor@apache.org> Closes #510 from nkalmar/branch-3.4 and squashes the following commits: 0ec9213 [Norbert Kalmar] ZOOKEEPER-3019 remove redundant log 63d3cb9 [Norbert Kalmar] Merge branch 'branch-3.4' of github.com:apache/zookeeper into branch-3.4 deb2543 [Norbert Kalmar] Merge branch 'branch-3.4' of github.com:apache/zookeeper into branch-3.4 336a83b [Norbert Kalmar] ZOOKEEPER-3019 add metric for slow fsyncs count
|
Merged to branch-3.4. Please close the PR @nkalmar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported fsync metric count from master.