Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZOOKEEPER-3097] Using Runnable instead of thread work items to improve the throughput of CommitProcessor #578

Closed
wants to merge 1 commit into from
Closed

[ZOOKEEPER-3097] Using Runnable instead of thread work items to improve the throughput of CommitProcessor #578

wants to merge 1 commit into from

Conversation

lvfangmin
Copy link
Contributor

No description provided.

hanm
hanm approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@hanm hanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since this is using ExecutorService already, there is no need to use Thread which is a little bit more cost to create than a runnable.

asfgit pushed a commit that referenced this pull request Jul 27, 2018
@hanm
ZOOKEEPER-3097: Using Runnable instead of thread work items to improv…
602cbe0 
…e the throughput of CommitProcessor

Author: Fangmin Lyu <allenlyu@fb.com>

Reviewers: Michael Han <hanm@apache.org>

Closes #578 from lvfangmin/ZOOKEEPER-3097

(cherry picked from commit 75c652f)
Signed-off-by: Michael Han <hanm@apache.org>
@asfgit asfgit closed this in 75c652f Jul 27, 2018
@hanm
Copy link
Contributor

hanm commented Jul 27, 2018

committed to 3.6/3.5. thanks @lvfangmin !

RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
@RokLenarcic
ZOOKEEPER-3097: Using Runnable instead of thread work items to improv…
891b0e9 
…e the throughput of CommitProcessor

Author: Fangmin Lyu <allenlyu@fb.com>

Reviewers: Michael Han <hanm@apache.org>

Closes apache#578 from lvfangmin/ZOOKEEPER-3097
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanm hanm hanm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lvfangmin @hanm