ZOOKEEPER-3112: fix fd leak due to UnresolvedAddressException on conn… #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch @PhantomThief |
|
@anmolnar a bad news is, after my test case, it won't fix the fd leak...so I'm adding an another patch. |
lvfangmin
reviewed
Aug 9, 2018
| // if UnresolvedAddressException throw on connect and it would leak a SocketChannelImpl in cancelledKeys EVERY time. | ||
| // it's hard to deal all situations on socks.cancel, | ||
| // while an easy way is, ensure DNS resolve successful before register channel. | ||
| InetAddress.getByName(addr.getHostName()); |
There was a problem hiding this comment.
Can you help me understand why sock.close won't clean up the fd?
If we have to check before register, I would suggest to use explicit check here, like:
if (addr.isUnresolved()) {
throw new UnresolvedAddressException();
}
|
We were recently bitten by this. Is there any reason why the original commit was updated? It seemed like that was the right fix. |
|
@PhantomThief |
I'm sorry that this patch cannot resolve this problem. I'm trying to make another patch. |
|
Due to @PhantomThief 's comment, I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ect.