Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZOOKEEPER-3146] Limit the maximum client connections per IP in NettyServerCnxnFactory #623

Closed
wants to merge 1 commit into from
Closed

[ZOOKEEPER-3146] Limit the maximum client connections per IP in NettyServerCnxnFactory #623

wants to merge 1 commit into from

Conversation

lvfangmin
Copy link
Contributor

Add similar max cnxn per ip throttling logic to Netty implementation.

hanm
hanm approved these changes Sep 14, 2018
View reviewed changes
Copy link
Contributor

@hanm hanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. kicking jenkins again.

@lvfangmin
Copy link
Contributor Author

@hanm looks like the Jenkins job is pending there since you triggered it 5 days ago, it doesn't likely will be run, can you trigger it again?

@hanm
Copy link
Contributor

hanm commented Sep 19, 2018

The job I triggered on Sep 14 actually succeeded. It's the github integration that's broken. I suspect it's some permission issues around apache github mirror, I'll follow up with this as it's annoying.

I think this issue is good to land. If no more comments, I'll commit it on Friday.

@hanm
Copy link
Contributor

hanm commented Sep 21, 2018

retest this please

@asfgit
Copy link

asfgit commented Sep 21, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2230/

@hanm
Copy link
Contributor

hanm commented Sep 21, 2018

retest this please

@asfgit
Copy link

asfgit commented Sep 21, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2231/

@hanm
Copy link
Contributor

hanm commented Sep 21, 2018

retest this please

@asfgit
Copy link

asfgit commented Sep 21, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2232/

@dineshappavoo
Copy link

Hey @lvfangmin ,
This change looks good overall.
I am trying to involve in the community. I had a question about this change. I thought I would ask here. Please bare with me if this is very basic which I do not know :).

  1. What is the difference between NIOServerCnxnFactory rate limiting and this one? What will be the impact after this change is merged?

Thanks.

@hanm
Copy link
Contributor

hanm commented Sep 22, 2018

the latest jenkins failure is a known flaky test. merging this in..

@asfgit asfgit closed this in 4ebb847 Sep 22, 2018
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
@RokLenarcic
ZOOKEEPER-3146: Limit the maximum client connections per IP in NettyS…
81767e7 
…erverCnxnFactory

Add similar max cnxn per ip throttling logic to Netty implementation.

Author: Fangmin Lyu <allenlyu@fb.com>

Reviewers: hanm@apache.org

Closes apache#623 from lvfangmin/ZOOKEEPER-3146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanm hanm hanm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@lvfangmin @hanm @asfgit @dineshappavoo