Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-1908: setAcl should be have a recursive function #666

Closed
wants to merge 3 commits into from
Closed

ZOOKEEPER-1908: setAcl should be have a recursive function #666

wants to merge 3 commits into from

Conversation

Reidddddd
Copy link
Contributor

Backport to branch-3.5.

@asfgit
Copy link

asfgit commented Oct 10, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2402/

@asfgit
Copy link

asfgit commented Oct 10, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2403/

@Reidddddd
Copy link
Contributor Author

I checkouted a new branch based on branch-3.5, and the PR base branch i chose is branch-3.5.
It should not have conflicts, anywhere i missed?

ping @anmolnar

@anmolnar
Copy link
Contributor

@Reidddddd You're probably facing with the Maven migration monster. Please check the conflicts.

anmolnar
anmolnar approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit
Copy link

asfgit commented Oct 10, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2404/

@Reidddddd
Copy link
Contributor Author

Shall we ping one more committer to give a review?

@anmolnar
Copy link
Contributor

Given that this is only the backport of #650 I think we're good to go.

asfgit pushed a commit that referenced this pull request Oct 12, 2018
@Reidddddd @anmolnar
ZOOKEEPER-1908: setAcl should be have a recursive function
ea1884e 
Backport to branch-3.5.

Author: Reid Chan <reidchan@apache.org>

Reviewers: andor@apache.org

Closes #666 from Reidddddd/zkp-1908 and squashes the following commits:

bcafaf4 [Reid Chan] Merge branch 'branch-3.5' into zkp-1908
be3f2e7 [Reid Chan] ZOOKEEPER-1908: Missed constructor change
e06aab2 [Reid Chan] ZOOKEEPER-1908: setAcl should be have a recursive function
@anmolnar
Copy link
Contributor

Committed to branch-3.5. Thanks @Reidddddd !
Please close this PR.

@Reidddddd Reidddddd closed this Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmolnar anmolnar anmolnar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Reidddddd @asfgit @anmolnar