[ZOOKEEPER-3203] Tracking the number of non voting followers in ZK #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Nov 26, 2018
| public String nonVotingFollowerInfo() { | ||
| StringBuilder sb = new StringBuilder(); | ||
| for (LearnerHandler handler : leader.getNonVotingFollowers()) { | ||
| sb.append(handler.toString()).append("\n"); |
There was a problem hiding this comment.
Wouldn't it be better to have a specific toStringForJMX method.
In the future people will change the toString method without thinking that they are changing the output of a public endpoint
There was a problem hiding this comment.
That's a fair point, but I'd like to keep the same behavior in this patch as what we're doing now for the followInfo in this LeaderBean.
There was a problem hiding this comment.
Ok I think we can live with it
lvfangmin
force-pushed
the
ZOOKEEPER-3203
branch
from
f093c2b
to
11456ff
Compare
|
retest this please |
|
Merged to master branch. Thanks @lvfangmin ! |
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
Author: Fangmin Lyu <fangmin@apache.org> Reviewers: andor@apache.org Closes apache#722 from lvfangmin/ZOOKEEPER-3203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.