ZOOKEEPER-3269 - Add queueEvent to the Testable facade #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add queueEvent to the Testable facade to enabled inserting events into the clients queue.
eolivelli
approved these changes
Feb 4, 2019
| import org.apache.zookeeper.ZooDefs; | ||
| import org.apache.zookeeper.ZooKeeper; | ||
| import org.apache.zookeeper.data.Stat; | ||
| import org.apache.zookeeper.*; |
There was a problem hiding this comment.
Nit: I am not sure we are preferring star import
|
LGTM |
|
@eolivelli Good catch, we do not. |
eolivelli
approved these changes
Feb 5, 2019
|
Refer to this link for build results (access rights to CI server needed): Failed Tests: 1PreCommit-ZOOKEEPER-github-pr-build-maven/org.apache.zookeeper:zookeeper-recipes-lock: 1--none----none-- |
|
That test failure has nothing to do with this PR BTW |
|
@Randgalt use the brand new magic words: @eolivelli Yes please. java + cpp is enough for pull requests |
|
Refer to this link for build results (access rights to CI server needed): Failed Tests: 1PreCommit-ZOOKEEPER-github-pr-build-maven/org.apache.zookeeper:zookeeper-server: 1--none----none-- |
|
@anmolnar we have new magic words.. retest maven build |
|
Refer to this link for build results (access rights to CI server needed): Build result: ABORTED[...truncated 86.73 KB...][INFO] Copying asm-5.0.4.jar to /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build-maven/zookeeper-server/target/lib/asm-5.0.4.jar[INFO] Copying kerb-admin-1.1.0.jar to /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build-maven/zookeeper-server/target/lib/kerb-admin-1.1.0.jar[INFO] Copying kerb-server-1.1.0.jar to /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build-maven/zookeeper-server/target/lib/kerb-server-1.1.0.jar[INFO] Copying kerb-identity-1.1.0.jar to /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build-maven/zookeeper-server/target/lib/kerb-identity-1.1.0.jar[INFO] Copying kerby-xdr-1.1.0.jar to /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build-maven/zookeeper-server/target/lib/kerby-xdr-1.1.0.jar[INFO] Copying kerby-config-1.1.0.jar to /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build-maven/zookeeper-server/target/lib/kerby-config-1.1.0.jar[INFO] Copying mockito-all-1.8.5.jar to /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build-maven/zookeeper-server/target/lib/mockito-all-1.8.5.jar[INFO] Copying junit-4.12.jar to /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build-maven/zookeeper-server/target/lib/junit-4.12.jar[INFO] Copying hamcrest-core-1.3.jar to /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build-maven/zookeeper-server/target/lib/hamcrest-core-1.3.jar[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: java.util.concurrent.ExecutionException: Invalid object ID 18 iota=25[INFO] [INFO] >>> spotbugs-maven-plugin:3.1.9:check (default-cli) > :spotbugs @ zookeeper-server >>>[INFO] [INFO] --- spotbugs-maven-plugin:3.1.9:spotbugs (spotbugs) @ zookeeper-server ---[INFO] Fork Value is true [java] SLF4J: No SLF4J providers were found. [java] SLF4J: Defaulting to no-operation (NOP) logger implementation [java] SLF4J: See http://www.slf4j.org/codes.html#noProviders for further details.Build was aborted[SpotBugs] Skipping execution of recorder since overall result is 'ABORTED' [java] channel stoppedSetting status of 0e3ab80 to FAILURE with url https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build-maven/27/ and message: 'FAILURE 'Using context: JenkinsMaven--none----none-- |
|
@eolivelli I'll commit this regardless of Maven failure. |
|
Merged to master. Thanks @Randgalt ! |
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
Add queueEvent to the Testable facade to enabled inserting events into the clients queue. For testing and other reasons it would be very useful to add a way to inject an event into ZooKeeper's event queue. ZooKeeper already has the Testable for features such as this (low level, backdoor, testing, etc.). This queueEvent method would be particularly helpful to Apache Curator and we'd very much appreciate its inclusion. Author: randgalt <jordan@jordanzimmerman.com> Reviewers: andor@apache.org Closes apache#799 from Randgalt/ZOOKEEPER-3269 and squashes the following commits: 0e3ab80 [randgalt] ZOOKEEPER-3269 - use explicit imports f77574b [randgalt] ZOOKEEPER-3269 remove IDE introduced spacing changes 8b5222d [randgalt] ZOOKEEPER-3269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add queueEvent to the Testable facade to enabled inserting events into the clients queue.
For testing and other reasons it would be very useful to add a way to inject an event into ZooKeeper's event queue. ZooKeeper already has the Testable for features such as this (low level, backdoor, testing, etc.). This queueEvent method would be particularly helpful to Apache Curator and we'd very much appreciate its inclusion.