Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-3028: MAVEN MIGRATION - 3.4 - Create maven assembly #814

Closed
wants to merge 2 commits into from

Conversation

nkalmar
Copy link
Contributor

@nkalmar nkalmar commented Feb 11, 2019

Author: Norbert Kalmar nkalmar@yahoo.com

Reviewers: andor@apache.org

Closes #776 from nkalmar/ZK-3028 and squashes the following commits:

c255d25 [Norbert Kalmar] ZOOKEEPER-3028 - fix javadoc warnings
b6ec90e [Norbert Kalmar] ZOOKEEPER-3028 - fix log4j.properties problem not getting into target
a54e49b [Norbert Kalmar] ZOOKEEPER-3028 - Remove empty test jar generation
be73ead [Norbert Kalmar] ZOOKEEPER-3028 - update README.md
d81a586 [Norbert Kalmar] ZOOKEEPER-3028 update relese procedures
4238935 [Norbert Kalmar] ZOOKEEPER-3028 - Add maven release procedure to readme.md
dc3ab01 [Norbert Kalmar] ZOOKEEPER-3028 - fix jars, add javadoc jar
07dfcf2 [Norbert Kalmar] ZOOKEEPER-3028 - move assembly descriptor
e22c708 [Norbert Kalmar] ZOOKEEPER-3028 - fix tarball to contain buildable source
859dfb9 [Norbert Kalmar] ZOOKEEPER-3028 add apache release
46c2f93 [Norbert Kalmar] ZOOKEEPER-3028 add release plugin
8c56e3c [Norbert Kalmar] ZOOKEEPER-3028 - Create maven assembly

@nkalmar nkalmar changed the title ZOOKEEPER-3028: MAVEN MIGRATION - - Create maven assembly ZOOKEEPER-3028: MAVEN MIGRATION - 3.4 - Create maven assembly Feb 11, 2019
Author: Norbert Kalmar <nkalmar@yahoo.com>

Reviewers: andor@apache.org

Closes apache#776 from nkalmar/ZK-3028 and squashes the following commits:

c255d25 [Norbert Kalmar] ZOOKEEPER-3028 - fix javadoc warnings
b6ec90e [Norbert Kalmar] ZOOKEEPER-3028 - fix log4j.properties problem not getting into target
a54e49b [Norbert Kalmar] ZOOKEEPER-3028 - Remove empty test jar generation
be73ead [Norbert Kalmar] ZOOKEEPER-3028 - update README.md
d81a586 [Norbert Kalmar] ZOOKEEPER-3028 update relese procedures
4238935 [Norbert Kalmar] ZOOKEEPER-3028 - Add maven release procedure to readme.md
dc3ab01 [Norbert Kalmar] ZOOKEEPER-3028 - fix jars, add javadoc jar
07dfcf2 [Norbert Kalmar] ZOOKEEPER-3028 - move assembly descriptor
e22c708 [Norbert Kalmar] ZOOKEEPER-3028 - fix tarball to contain buildable source
859dfb9 [Norbert Kalmar] ZOOKEEPER-3028 add apache release
46c2f93 [Norbert Kalmar] ZOOKEEPER-3028 add release plugin
8c56e3c [Norbert Kalmar] ZOOKEEPER-3028 - Create maven assembly
@nkalmar
Copy link
Contributor Author

nkalmar commented Feb 14, 2019

retest maven build

@nkalmar
Copy link
Contributor Author

nkalmar commented Feb 21, 2019

I created a new jira for the test failures. See
https://issues.apache.org/jira/browse/ZOOKEEPER-3284

This patch has nothing to do with them, and it's only on 3.4
Let's not block ZOOKEEPER-3028 as it also blocks 3.5 release.

asfgit pushed a commit that referenced this pull request Feb 21, 2019
Author: Norbert Kalmar <nkalmaryahoo.com>

Reviewers: andorapache.org

Closes #776 from nkalmar/ZK-3028 and squashes the following commits:

c255d25 [Norbert Kalmar] ZOOKEEPER-3028 - fix javadoc warnings
b6ec90e [Norbert Kalmar] ZOOKEEPER-3028 - fix log4j.properties problem not getting into target
a54e49b [Norbert Kalmar] ZOOKEEPER-3028 - Remove empty test jar generation
be73ead [Norbert Kalmar] ZOOKEEPER-3028 - update README.md
d81a586 [Norbert Kalmar] ZOOKEEPER-3028 update relese procedures
4238935 [Norbert Kalmar] ZOOKEEPER-3028 - Add maven release procedure to readme.md
dc3ab01 [Norbert Kalmar] ZOOKEEPER-3028 - fix jars, add javadoc jar
07dfcf2 [Norbert Kalmar] ZOOKEEPER-3028 - move assembly descriptor
e22c708 [Norbert Kalmar] ZOOKEEPER-3028 - fix tarball to contain buildable source
859dfb9 [Norbert Kalmar] ZOOKEEPER-3028 add apache release
46c2f93 [Norbert Kalmar] ZOOKEEPER-3028 add release plugin
8c56e3c [Norbert Kalmar] ZOOKEEPER-3028 - Create maven assembly

Author: Norbert Kalmar <nkalmar@yahoo.com>

Reviewers: andor@apache.org

Closes #814 from nkalmar/ZK-3028_3.4 and squashes the following commits:

f3a2f05 [Norbert Kalmar] ZOOKEEPER-3028 - fix failing unit tests when runing maven
52d6574 [Norbert Kalmar] ZOOKEEPER-3028: MAVEN MIGRATION - - Create maven assembly
@anmolnar
Copy link
Contributor

Committed to 3.4 Thanks @nkalmar !

@anmolnar anmolnar closed this Feb 21, 2019
@nkalmar nkalmar deleted the ZK-3028_3.4 branch October 6, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants