ZOOKEEPER-3275: Fix release targets: package, tar, mvn-deploy (3.4) #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed recipes and contrib path names for package and tar targets. Author: Andor Molnar <andor@apache.org> Reviewers: andor@apache.org Closes apache#817 from anmolnar/ZOOKEEPER-3275 and squashes the following commits: 64db892 [Andor Molnar] ZOOKEEPER-3275. Fixed bin-package target e8ad3d4 [Andor Molnar] ZOOKEEPER-3275. Added pom.xml to tar file, fixed mvn-deploy task 6667c2f [Andor Molnar] ZOOKEEPER-3275. Updated release audit warnings exlcudes 5abf3b4 [Andor Molnar] ZOOKEEPER-3275. Fixed path of contrib and docs project 4e97ae8 [Andor Molnar] ZOOKEEPER-3275. Fixed recipes folders in ant package target
nkalmar
requested changes
Feb 13, 2019
| <mkdir dir="${dist.dir}/contrib/${name}/config" /> | ||
| <copy todir="${dist.dir}/contrib/${name}/config"> | ||
| <mkdir dir="${dist.dir}/zookeeper-contrib/zookeeper-contrib-${name}/config" /> | ||
| <copy todir="${dist.dir}/zookeeper-contrib/zookeeper-contrib-${name}/config"> | ||
| <fileset dir="${basedir}/src/main/resources"> | ||
| <include name="defaultConnectionSettings.cfg" /> | ||
| <include name="defaultNodeViewers.cfg" /> |
There was a problem hiding this comment.
Please modify the 2 copy tasks at the bottom of this file:
Should be:
${dist.dir}/zookeeper-contrib/zookeeper-contrib-${name}/lib
|
retest maven build |
asfgit
pushed a commit
that referenced
this pull request
Feb 13, 2019
Fixed recipes and contrib path names for package and tar targets. Author: Andor Molnar <andorapache.org> Reviewers: andorapache.org Closes #817 from anmolnar/ZOOKEEPER-3275 and squashes the following commits: 64db892 [Andor Molnar] ZOOKEEPER-3275. Fixed bin-package target e8ad3d4 [Andor Molnar] ZOOKEEPER-3275. Added pom.xml to tar file, fixed mvn-deploy task 6667c2f [Andor Molnar] ZOOKEEPER-3275. Updated release audit warnings exlcudes 5abf3b4 [Andor Molnar] ZOOKEEPER-3275. Fixed path of contrib and docs project 4e97ae8 [Andor Molnar] ZOOKEEPER-3275. Fixed recipes folders in ant package target Author: Andor Molnar <andor@apache.org> Reviewers: andor@apache.org Closes #818 from anmolnar/ZOOKEEPER-3275_34 and squashes the following commits: e04336f [Andor Molnar] ZOOKEEPER-3275. Fixed tiny copy-and-paste error 539951a [Andor Molnar] ZOOKEEPER-3275. Added some missing release audit excludes a5cc9e2 [Andor Molnar] ZOOKEEPER-3275: Fix release targets: package, tar, mvn-deploy
|
Committed, because Ant build is green. Thanks @nkalmar ! |
asfgit
pushed a commit
that referenced
this pull request
Feb 13, 2019
Fixed recipes and contrib path names for package and tar targets. Author: Andor Molnar <andorapache.org> Reviewers: andorapache.org Closes #817 from anmolnar/ZOOKEEPER-3275 and squashes the following commits: 64db892 [Andor Molnar] ZOOKEEPER-3275. Fixed bin-package target e8ad3d4 [Andor Molnar] ZOOKEEPER-3275. Added pom.xml to tar file, fixed mvn-deploy task 6667c2f [Andor Molnar] ZOOKEEPER-3275. Updated release audit warnings exlcudes 5abf3b4 [Andor Molnar] ZOOKEEPER-3275. Fixed path of contrib and docs project 4e97ae8 [Andor Molnar] ZOOKEEPER-3275. Fixed recipes folders in ant package target Author: Andor Molnar <andor@apache.org> Reviewers: andor@apache.org Closes #818 from anmolnar/ZOOKEEPER-3275_34 and squashes the following commits: e04336f [Andor Molnar] ZOOKEEPER-3275. Fixed tiny copy-and-paste error 539951a [Andor Molnar] ZOOKEEPER-3275. Added some missing release audit excludes a5cc9e2 [Andor Molnar] ZOOKEEPER-3275: Fix release targets: package, tar, mvn-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed recipes and contrib path names for package and tar targets.
Author: Andor Molnar andor@apache.org
Reviewers: andor@apache.org
Closes #817 from anmolnar/ZOOKEEPER-3275 and squashes the following commits:
64db892 [Andor Molnar] ZOOKEEPER-3275. Fixed bin-package target
e8ad3d4 [Andor Molnar] ZOOKEEPER-3275. Added pom.xml to tar file, fixed mvn-deploy task
6667c2f [Andor Molnar] ZOOKEEPER-3275. Updated release audit warnings exlcudes
5abf3b4 [Andor Molnar] ZOOKEEPER-3275. Fixed path of contrib and docs project
4e97ae8 [Andor Molnar] ZOOKEEPER-3275. Fixed recipes folders in ant package target