Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven migration - ZOOKEEPER-3285 add convenience tar, assembly module and sha512 generation #828

Closed
wants to merge 5 commits into from

Conversation

nkalmar
Copy link
Contributor

@nkalmar nkalmar commented Feb 21, 2019

No description provided.

@nkalmar
Copy link
Contributor Author

nkalmar commented Feb 21, 2019

As noted in the jira, this is just for master and 3.5 branches.

@nkalmar
Copy link
Contributor Author

nkalmar commented Feb 21, 2019

retest ant please

@nkalmar
Copy link
Contributor Author

nkalmar commented Feb 21, 2019

retest ant build

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work.
I left a couple of comments

zookeeper-assembly/pom.xml Outdated Show resolved Hide resolved
zookeeper-assembly/pom.xml Outdated Show resolved Hide resolved
zookeeper-assembly/src/main/assembly/source-package.xml Outdated Show resolved Hide resolved
@nkalmar
Copy link
Contributor Author

nkalmar commented Feb 24, 2019

retest maven build

pom.xml Show resolved Hide resolved
@nkalmar
Copy link
Contributor Author

nkalmar commented Feb 25, 2019

retest ant build

@nkalmar
Copy link
Contributor Author

nkalmar commented Feb 26, 2019

@eolivelli can you take a look again please?
I fixed your comments.
Thanks!

Copy link
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in 54b4f8a Feb 26, 2019
asfgit pushed a commit that referenced this pull request Feb 26, 2019
…e and sha512 generation

Author: Norbert Kalmar <nkalmar@yahoo.com>

Reviewers: andor@apache.org

Closes #828 from nkalmar/master and squashes the following commits:

817077f [Norbert Kalmar] ZOOKEEPER-3285 - add some info on 3rd party plugin
af1fcd5 [Norbert Kalmar] ZOOKEEPER-3285 - remove zip generation and fix versions
c19d186 [Norbert Kalmar] ZOOKEEPER-3285 - add Apache license headers
4e7b659 [Norbert Kalmar] ZOOKEEPER-3285 - add auto sha512 checksum generation for all maven generated artifact
915d530 [Norbert Kalmar] ZOOKEEPER-3285 - create convenience tar and assembly sub-module

(cherry picked from commit 54b4f8a)
Signed-off-by: Andor Molnar <andor@apache.org>
@anmolnar
Copy link
Contributor

Merged to 3.5 and master. Thanks @nkalmar !

maoling pushed a commit to maoling/zookeeper that referenced this pull request Mar 13, 2019
…e and sha512 generation

Author: Norbert Kalmar <nkalmar@yahoo.com>

Reviewers: andor@apache.org

Closes apache#828 from nkalmar/master and squashes the following commits:

817077f [Norbert Kalmar] ZOOKEEPER-3285 - add some info on 3rd party plugin
af1fcd5 [Norbert Kalmar] ZOOKEEPER-3285 - remove zip generation and fix versions
c19d186 [Norbert Kalmar] ZOOKEEPER-3285 - add Apache license headers
4e7b659 [Norbert Kalmar] ZOOKEEPER-3285 - add auto sha512 checksum generation for all maven generated artifact
915d530 [Norbert Kalmar] ZOOKEEPER-3285 - create convenience tar and assembly sub-module
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
…e and sha512 generation

Author: Norbert Kalmar <nkalmar@yahoo.com>

Reviewers: andor@apache.org

Closes apache#828 from nkalmar/master and squashes the following commits:

817077f [Norbert Kalmar] ZOOKEEPER-3285 - add some info on 3rd party plugin
af1fcd5 [Norbert Kalmar] ZOOKEEPER-3285 - remove zip generation and fix versions
c19d186 [Norbert Kalmar] ZOOKEEPER-3285 - add Apache license headers
4e7b659 [Norbert Kalmar] ZOOKEEPER-3285 - add auto sha512 checksum generation for all maven generated artifact
915d530 [Norbert Kalmar] ZOOKEEPER-3285 - create convenience tar and assembly sub-module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants