New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maven migration - ZOOKEEPER-3285 add convenience tar, assembly module and sha512 generation #828
Conversation
As noted in the jira, this is just for master and 3.5 branches. |
retest ant please |
retest ant build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work.
I left a couple of comments
retest maven build |
retest ant build |
@eolivelli can you take a look again please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…e and sha512 generation Author: Norbert Kalmar <nkalmar@yahoo.com> Reviewers: andor@apache.org Closes #828 from nkalmar/master and squashes the following commits: 817077f [Norbert Kalmar] ZOOKEEPER-3285 - add some info on 3rd party plugin af1fcd5 [Norbert Kalmar] ZOOKEEPER-3285 - remove zip generation and fix versions c19d186 [Norbert Kalmar] ZOOKEEPER-3285 - add Apache license headers 4e7b659 [Norbert Kalmar] ZOOKEEPER-3285 - add auto sha512 checksum generation for all maven generated artifact 915d530 [Norbert Kalmar] ZOOKEEPER-3285 - create convenience tar and assembly sub-module (cherry picked from commit 54b4f8a) Signed-off-by: Andor Molnar <andor@apache.org>
Merged to 3.5 and master. Thanks @nkalmar ! |
…e and sha512 generation Author: Norbert Kalmar <nkalmar@yahoo.com> Reviewers: andor@apache.org Closes apache#828 from nkalmar/master and squashes the following commits: 817077f [Norbert Kalmar] ZOOKEEPER-3285 - add some info on 3rd party plugin af1fcd5 [Norbert Kalmar] ZOOKEEPER-3285 - remove zip generation and fix versions c19d186 [Norbert Kalmar] ZOOKEEPER-3285 - add Apache license headers 4e7b659 [Norbert Kalmar] ZOOKEEPER-3285 - add auto sha512 checksum generation for all maven generated artifact 915d530 [Norbert Kalmar] ZOOKEEPER-3285 - create convenience tar and assembly sub-module
…e and sha512 generation Author: Norbert Kalmar <nkalmar@yahoo.com> Reviewers: andor@apache.org Closes apache#828 from nkalmar/master and squashes the following commits: 817077f [Norbert Kalmar] ZOOKEEPER-3285 - add some info on 3rd party plugin af1fcd5 [Norbert Kalmar] ZOOKEEPER-3285 - remove zip generation and fix versions c19d186 [Norbert Kalmar] ZOOKEEPER-3285 - add Apache license headers 4e7b659 [Norbert Kalmar] ZOOKEEPER-3285 - add auto sha512 checksum generation for all maven generated artifact 915d530 [Norbert Kalmar] ZOOKEEPER-3285 - create convenience tar and assembly sub-module
No description provided.