ZOOKEEPER-3351 - Fix findBugs and rat check, add filename to sha #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Please add the spotbugs ignore. |
eolivelli
reviewed
Apr 12, 2019
|
Tested spotBugs, it now passes with versions without SNAPSHOT as well. Testing this patch on 3.5 branch to see if it can be merged or new PR is required. Edit: This PR fixes 3.5 branch as well, but it is conflicting, so I'll create a PR for 3.5 anyway. |
nkalmar
changed the title
anmolnar
reviewed
Apr 12, 2019
| @@ -41,6 +42,8 @@ public static String getBuildDate() { | |||
| return BUILD_DATE; | |||
| } | |||
|
|
|||
| @SuppressFBWarnings(value = "RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE", | |||
| justification = "If SNAPSHOT is missing from version number this is redundant") | |||
There was a problem hiding this comment.
Let's say "QUALIFIER" instead of "SNAPSHOT".
There was a problem hiding this comment.
Rephased the message
eolivelli
approved these changes
Apr 12, 2019
|
retest ant build |
|
Committed to master branch. Thanks @nkalmar ! |
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
Note: this is only for master, for 3.5 branch it needs a different PR! Correction: I will test this on 3.5 branch first! Author: Norbert Kalmar <nkalmar@yahoo.com> Reviewers: andor@apache.org Closes apache#907 from nkalmar/ZK-3351 and squashes the following commits: ca77153 [Norbert Kalmar] ZOOKEEPER-3351 - fix findBugs issue on released versions 161df0b [Norbert Kalmar] ZOOKEEPER-3351 - add rat exceptions and fix sha generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is only for master, for 3.5 branch it needs a different PR!
Correction: I will test this on 3.5 branch first!