[ZOOKEEPER-3387] Use BufferedWriter instead of FileWriter #941
+432
−417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Though the build checks have failed due to other reason, the BufferedWriter -> FileWriter changes still remain valid and applicable to the code base |
eolivelli
reviewed
May 18, 2019
eolivelli
reviewed
May 18, 2019
|
retest this please |
anmolnar
reviewed
May 29, 2019
There was a problem hiding this comment.
As outlined by @eolivelli this is a build-time only improvement. I appreciate your contribution @bd2019us , but Jute is not maintained anymore and we want to replace it in the long run.
How much time do you gain in build time with this change?
|
@bd2019us This patch doesn't compile: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZOOKEEPER-3387 When FileWriter is used intensively within a loop, BufferedWriter can be used to improve performance by reducing IO operations.