Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY #957

Closed
wants to merge 2 commits into from
Closed

ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY #957

wants to merge 2 commits into from

Conversation

jhuan31
Copy link

@jhuan31 jhuan31 commented May 23, 2019

No description provided.

@eolivelli
Copy link
Contributor

retest ant build

@eolivelli
Copy link
Contributor

retest maven build

nkalmar
nkalmar requested changes May 24, 2019
View reviewed changes
Copy link
Contributor

@nkalmar nkalmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update LearnerMetricsTest.testLearnerMetricsTest

@jhuan31
Copy link
Author

jhuan31 commented May 24, 2019

Thank you @nkalmar. Fixed the unit test.

@nkalmar
Copy link
Contributor

nkalmar commented May 27, 2019

retest ant build

nkalmar
nkalmar approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@nkalmar nkalmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to +1 after the fix, thanks @jhuan31 , LGTM!

@asfgit asfgit closed this in bb94aa4 May 28, 2019
@nkalmar
Copy link
Contributor

nkalmar commented May 28, 2019

Thanks @jhuan31 , merged to master.

RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
@RokLenarcic
ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY
1d6efc0 
Author: Jie Huang <jiehuang@fb.com>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Norbert Kalmar <nkalmar@apache.org>

Closes apache#957 from jhuan31/ZOOKEEPER-3401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkalmar nkalmar nkalmar approved these changes

@eolivelli eolivelli eolivelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jhuan31 @eolivelli @nkalmar