ZOOKEEPER-2479 #98
ZOOKEEPER-2479 #98
Conversation
| * Keeps time taken for leader election in milliseconds. Sets the value to | ||
| * this variable only after the completion of leader election. | ||
| */ | ||
| private long electionTimeTaken = -1; |
There was a problem hiding this comment.
sincere question: does it make sense to make this field volatile? I know there are some concurrency guarantees but not sure if it's worth change it.
There was a problem hiding this comment.
Thanks @eribeiro ,
LeaderMXBean, FollowerMXBean will be available only after the quorum leader election and the value won't be changed until next LE. I think, adding 'volatile' doesn't make any difference, right?
code reference:
https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/quorum/Leader.java#L417
https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/quorum/Follower.java#L70
Leader.java
zk.registerJMX(new LeaderBean(this, zk), self.jmxLocalPeerBean);
Follower.java
fzk.registerJMX(new FollowerBean(this, zk), self.jmxLocalPeerBean);
There was a problem hiding this comment.
Yup, agree. :) Thanks for explaining!
|
+1, LGTM. @eribeiro is this ready according to you? |
|
@eribeiro ,, appreciate your feedback. Thanks! |
| String bean = ""; | ||
| if (qp.getPeerState() == ServerState.FOLLOWING) { | ||
| bean = CommonNames.DOMAIN + ":name0=ReplicatedServer_id" + i | ||
| + ",name1=replica." + i + ",name2=Follower"; |
There was a problem hiding this comment.
hyper nit: String.format() reads better than +
There was a problem hiding this comment.
Thanks @rgs1, I've have modified the test code as per your suggestion. Please take another look at the new commits.
| electionTimeTaken >= 0); | ||
| } else if (qp.getPeerState() == ServerState.LEADING) { | ||
| bean = CommonNames.DOMAIN + ":name0=ReplicatedServer_id" + i | ||
| + ",name1=replica." + i + ",name2=Leader"; |
…lowerMXBean Author: Rakesh Radhakrishnan <rakeshr@apache.org> Reviewers: Edward Ribeiro <edward.ribeiro@gmail.com>, fpj <fpj@apache.org> Closes #98 from rakeshadr/ZK-2479 and squashes the following commits: 2c9eadf [Rakesh Radhakrishnan] ZOOKEEPER-2479: avoids duplicate code 5af1314 [Rakesh Radhakrishnan] ZOOKEEPER-2479: Fixed Raul's review comments cc011a0 [Rakesh Radhakrishnan] ZOOKEEPER-2479: Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean (cherry picked from commit 8616a9e) Signed-off-by: fpj <fpj@apache.org>
…lowerMXBean Author: Rakesh Radhakrishnan <rakeshr@apache.org> Reviewers: Edward Ribeiro <edward.ribeiro@gmail.com>, fpj <fpj@apache.org> Closes apache#98 from rakeshadr/ZK-2479 and squashes the following commits: 2c9eadf [Rakesh Radhakrishnan] ZOOKEEPER-2479: avoids duplicate code 5af1314 [Rakesh Radhakrishnan] ZOOKEEPER-2479: Fixed Raul's review comments cc011a0 [Rakesh Radhakrishnan] ZOOKEEPER-2479: Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
…lowerMXBean Author: Rakesh Radhakrishnan <rakeshr@apache.org> Reviewers: Edward Ribeiro <edward.ribeiro@gmail.com>, fpj <fpj@apache.org> Closes apache#98 from rakeshadr/ZK-2479 and squashes the following commits: 2c9eadf [Rakesh Radhakrishnan] ZOOKEEPER-2479: avoids duplicate code 5af1314 [Rakesh Radhakrishnan] ZOOKEEPER-2479: Fixed Raul's review comments cc011a0 [Rakesh Radhakrishnan] ZOOKEEPER-2479: Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
No description provided.