ZOOKEEPER-3440 Fix Apache RAT check by excluding binary files (images) #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eolivelli
commented
Jun 22, 2019
•
eolivelli
commented
- Fix Apache Rat plugin configuration (make it pass against C client, docs and contrib module)
- Add apache-rat:check on Travis
|
@anmolnar @nkalmar @phunt the patch is now ready, as already said on JIRA (https://issues.apache.org/jira/browse/ZOOKEEPER-3440) I don't like that exclusions we should take care of cleaning up the contrib module By now we can fix the pom as I am suggesting |
nkalmar
approved these changes
Jun 24, 2019
|
Should this fix go to 3.5 as well? Looks to me it should have the same problem. |
|
@nkalmar I image so, as we are using Maven in zk 3.5 it is better to apply the fix there. |
hanm
approved these changes
Jun 28, 2019
stickyhipp
pushed a commit
to stickyhipp/zookeeper
that referenced
this pull request
Aug 2, 2019
- Fix Apache Rat plugin configuration (make it pass against C client, docs and contrib module) - Add apache-rat:check on Travis Author: Enrico Olivelli <eolivelli@apache.org> Reviewers: Andor Molnár <andor@apache.org>, Norbert Kalmar <nkalmar@yahoo.com>, Michael Han <hanm@apache.org> Closes apache#998 from eolivelli/fix/ZOOKEEPER-3440-rat
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
- Fix Apache Rat plugin configuration (make it pass against C client, docs and contrib module) - Add apache-rat:check on Travis Author: Enrico Olivelli <eolivelli@apache.org> Reviewers: Andor Molnár <andor@apache.org>, Norbert Kalmar <nkalmar@yahoo.com>, Michael Han <hanm@apache.org> Closes apache#998 from eolivelli/fix/ZOOKEEPER-3440-rat
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
- Fix Apache Rat plugin configuration (make it pass against C client, docs and contrib module) - Add apache-rat:check on Travis Author: Enrico Olivelli <eolivelli@apache.org> Reviewers: Andor Molnár <andor@apache.org>, Norbert Kalmar <nkalmar@yahoo.com>, Michael Han <hanm@apache.org> Closes apache#998 from eolivelli/fix/ZOOKEEPER-3440-rat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.