Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #60

Closed
wants to merge 1 commit into from
Closed

Update README.md #60

wants to merge 1 commit into from

Conversation

shmidtelson
Copy link

fix: Syntax error has been fixed in an example

fix: Syntax error has been fixed in an example
Copy link
Collaborator

@imranbarbhuiya imranbarbhuiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was imported as NextNProgress so it should be used as NextNProgress

import NextNProgress from 'nextjs-progressbar';

export default function MyApp({ Component, pageProps }) {
  return (
    <>
      <NextNProgress />
      <Component {...pageProps} />;
    </>
  );
}

How to use

@shmidtelson
Copy link
Author

Why is it different?
I got error, because i copied from one place import and from other place <NextNProgress/>

@imranbarbhuiya
Copy link
Collaborator

Why is it different? I got error, because i copied from one place import and from other place <NextNProgress/>

It's upto you what you wanna name it. You can give anything in import and later on you need to use the same name what you've used in import.

@imranbarbhuiya imranbarbhuiya added invalid This doesn't seem right and removed invalid This doesn't seem right labels Nov 2, 2021
@imranbarbhuiya
Copy link
Collaborator

Now I understood what you were saying. In Readme.md, both NextNprogress and NextNProgress were present. Thank you for the PR, but this PR needs some more changes, so I've included these changes in my PR. Will be fixed in next patch update.

@shmidtelson
Copy link
Author

shmidtelson commented Nov 2, 2021

@imranbarbhuiya
Ok! Thank you for detailed answer. I just wanted to make a bit better your project

@imranbarbhuiya
Copy link
Collaborator

Fixed in #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants