Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlock log message #2760

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Fix deadlock log message #2760

merged 4 commits into from
Oct 19, 2023

Conversation

thpani
Copy link
Collaborator

@thpani thpani commented Oct 17, 2023

Fix a log message. This was printing Only deadlocks will be checked even with --no-deadlocks.

Fixes #2118

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entries added to ./unreleased/ for any new functionality

@Kukovec
Copy link
Collaborator

Kukovec commented Oct 17, 2023

Can you explain how changing the predicates class affects the log message? It's not obvious from the diff

@konnov
Copy link
Collaborator

konnov commented Oct 18, 2023

Can you explain how changing the predicates class affects the log message? It's not obvious from the diff

I am also not sure. What are derived predicates?

@thpani
Copy link
Collaborator Author

thpani commented Oct 18, 2023

Can you explain how changing the predicates class affects the log message? It's not obvious from the diff

It doesn't.
DerivedPredicates just does not contain the checker options (like --no-deadlocks) so we have to inject a trait that contains this superset of options.

But I also messed it up, HasCheckerPreds is injectible while WithCheckerPreds is not. Fix in 363c9ee.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Merging #2760 (17d3bf4) into main (2c336c1) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2760      +/-   ##
==========================================
- Coverage   78.86%   78.83%   -0.03%     
==========================================
  Files         465      465              
  Lines       15895    15896       +1     
  Branches     2590     2605      +15     
==========================================
- Hits        12535    12532       -3     
- Misses       3360     3364       +4     
Files Coverage Δ
...syte/apalache/tla/bmcmt/passes/VCGenPassImpl.scala 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Kukovec Kukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thpani thpani enabled auto-merge (squash) October 19, 2023 13:39
@thpani thpani merged commit ada2323 into main Oct 19, 2023
10 checks passed
@thpani thpani deleted the th/log-deadlogs branch October 20, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When no invariants are configured, we report checking deadlocks even if --no-deadlocks is set
4 participants