-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deadlock log message #2760
Fix deadlock log message #2760
Conversation
Can you explain how changing the predicates class affects the log message? It's not obvious from the diff |
I am also not sure. What are derived predicates? |
It doesn't. But I also messed it up, |
Codecov Report
@@ Coverage Diff @@
## main #2760 +/- ##
==========================================
- Coverage 78.86% 78.83% -0.03%
==========================================
Files 465 465
Lines 15895 15896 +1
Branches 2590 2605 +15
==========================================
- Hits 12535 12532 -3
- Misses 3360 3364 +4
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
be45623
to
cafbab8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cafbab8
to
17d3bf4
Compare
Fix a log message. This was printing
Only deadlocks will be checked
even with--no-deadlocks
.Fixes #2118
Tests added for any new codemake fmt-fix
(or had formatting run automatically on all files edited)Documentation added for any new functionalityEntries added to./unreleased/
for any new functionality