Ability to include theme without importing bootstrap from pre-defined path added #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, that's absolutely fine, I'll go ahead and merge this |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have bootstrap 5 as part of my project already. So I do not need this theme to be compiled as separate css but include it in my composite css.
When I include
select2-bootstrap-5-theme.scssI have problem with this lines:@import "node_modules/bootstrap/scss/xxx";This is because I have bootstrap at another path (I do not use npm in this project at all).
With this pull request I add
_include-all.scssfile to be included separately in such custom cases. Andselect2-bootstrap-5-theme.scssjust imports it after importing bootstrap dependencies.Checked everything to be compiled with gulp.