'Compression' feature #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const string GPS_DESC = "gps"; | ||
| const string GPS_COORD_LAT_FIELD = "lat"; | ||
| const string GPS_COORD_LNG_FIELD = "lng"; | ||
| const string GPS_TIME_FIELD = "Time"; |
There was a problem hiding this comment.
There is an optional timestamp attribute within every metadata item, let's use it instead.
|
@apavlenko , all your comments until this moment are fixed, please check the solutions |
| { | ||
| string algo; | ||
| compressedXMP->GetProperty(VMF_NS, compressionAlgoPropName.c_str(), &algo, NULL); | ||
| if(!algo.empty()) |
There was a problem hiding this comment.
fixed, throw an exception if no algo name is given
savuor
force-pushed
the
rv/compression_prototype
branch
3 times, most recently
from
22659d7
to
fbd8e7c
Compare
| void XMPDataSource::loadXMPstructs() | ||
| { | ||
| std::shared_ptr<SXMPMeta> compressedXMP = make_shared<SXMPMeta>(); | ||
| //xmpFile.GetXMP(NULL, &buffer, NULL); |
There was a problem hiding this comment.
let's cleanup replaced code, VCS should keep it, not comments
…ter classed added, WIP
…stead of parseAll()
savuor
force-pushed
the
rv/compression_prototype
branch
from
30756b5
to
82d410a
Compare
|
👍 |
1 similar comment
|
👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2 for details