Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to translate every message in eng #7

Open
apavlidi opened this issue Jul 16, 2018 · 4 comments
Open

We need to translate every message in eng #7

apavlidi opened this issue Jul 16, 2018 · 4 comments
Labels
good first issue Good for newcomers

Comments

@apavlidi
Copy link
Owner

No description provided.

@apavlidi apavlidi added the good first issue Good for newcomers label Aug 14, 2018
@iamaldi
Copy link
Contributor

iamaldi commented Dec 1, 2018

What exactly needs to be done here? Which messages need to be translated?

Thanks
Aldi

@apavlidi
Copy link
Owner Author

apavlidi commented Dec 1, 2018

Every response message that is returned from the API needs to be in English and not in Greek. for example here

next(new ApplicationError('getAnnouncement', null, 1022, err, 'Δεν έχεις δικάιωμα για αυτήν την ενέργεια!', getClientIp(req), 401, false))

One solution may be a hard code change with English text. Another solution may be with i18n npm module which supports multilingual.

@iamaldi
Copy link
Contributor

iamaldi commented Dec 1, 2018 via email

@apavlidi
Copy link
Owner Author

apavlidi commented Dec 1, 2018

This is the way to go actually. The i18n npm module supports that and I would recommend using it as I used in the past and solved the language issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants