Honor User Settings #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No clue why I have to add the setTimeout 0 that reloads the markup again and draws; but it doesn't work without it ¯\_(ツ)_/¯.
Added the notion of default values for settings so we an have a null object pattern for localStorage.getItem.
|
Hi @leviwilson I'm really sorry for having missed this PR - it must have got buried under a massive pile of github notifications! I don't have a laptop available at the moment, but will hopefully look at this in about 3 weeks time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the page is reloaded, though the data is in
localStorage, it didn't honor which style was selected. I've modified it so that on page load it will load your last selected style.Additionally I've added the
internalScaleas a saved setting as well that is honored when your page reloads.It still has an issue when you first save a new style from the dialog (you have to do it twice before it re-paints?) but I can look at that later.