Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve frontend and configmap for greptimedb #4855

Merged
merged 3 commits into from
Aug 24, 2023
Merged

fix: improve frontend and configmap for greptimedb #4855

merged 3 commits into from
Aug 24, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Aug 24, 2023

Fixes #4827

  • add a env for meta to fix the inner bug for greptimedb
  • add init containers for components to refine startup order
  • using configSpec to mount configmap

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Aug 24, 2023
@shanshanying
Copy link
Contributor

@ldming @wangyelei @heng4fun pls help review

heng4fun
heng4fun approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@heng4fun heng4fun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanshanying
Copy link
Contributor

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Aug 24, 2023
@shanshanying shanshanying merged commit 7584e8d into apecloud:main Aug 24, 2023
34 checks passed
@shawnh2 shawnh2 deleted the greptimedb/fix-fe-config branch August 24, 2023 06:14
@shanshanying
Copy link
Contributor

/cherry-pick release-0.6

@github-actions
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/6639562361

github-actions bot pushed a commit that referenced this pull request Oct 25, 2023
@shawnh2 @shanshanying
fix: improve frontend and configmap for greptimedb (#4855)
b7b942b 
(cherry picked from commit 7584e8d)
ldming pushed a commit that referenced this pull request Nov 21, 2023
@shawnh2 @ldming
fix: improve frontend and configmap for greptimedb (#4855)
084abfe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangyelei wangyelei wangyelei approved these changes

@apecloud-bot apecloud-bot apecloud-bot approved these changes

@nayutah nayutah Awaiting requested review from nayutah nayutah is a code owner

@ldming ldming Awaiting requested review from ldming ldming is a code owner

@free6om free6om Awaiting requested review from free6om free6om is a code owner

@leon-inf leon-inf Awaiting requested review from leon-inf

@heng4fun heng4fun Awaiting requested review from heng4fun heng4fun is a code owner

Assignees
No one assigned
Labels
approved PR Approved Test enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]GrepTime - Improve FrontEnd and ConfigMap
5 participants
@shawnh2 @shanshanying @heng4fun @wangyelei @apecloud-bot