Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Serial UpdateStrategy not working without roles #7079

Merged

Conversation

free6om
Copy link
Contributor

@free6om free6om commented Apr 17, 2024

fixed #6785

@free6om free6om added this to the Release 0.8.3 milestone Apr 17, 2024
@free6om free6om self-assigned this Apr 17, 2024
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 65.54%. Comparing base (654f3bb) to head (4ba8693).

Files Patch % Lines
pkg/controller/rsm/update_plan.go 33.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.8    #7079      +/-   ##
===============================================
+ Coverage        65.49%   65.54%   +0.04%     
===============================================
  Files              306      306              
  Lines            38066    38069       +3     
===============================================
+ Hits             24932    24952      +20     
+ Misses           10986    10971      -15     
+ Partials          2148     2146       -2     
Flag Coverage Δ
unittests 65.54% <33.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@free6om free6om merged commit c6f4181 into release-0.8 Apr 17, 2024
56 of 58 checks passed
@free6om free6om deleted the bugfix/serial-update-strategy-not-working-without-roles branch April 17, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] RSM SerialUpdateStrategy does not support engine components without roles
2 participants