Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add labels to distinguish kb and dataprotection #7352

Merged
merged 1 commit into from
May 15, 2024

Conversation

shanshanying
Copy link
Contributor

@shanshanying shanshanying commented May 15, 2024

and here is an example of values to deploy KB with 3 replicas, and specify extraLables, affinity and antiaffinity for KB and DP respectively.

helm -n kb-system upgrade -i kubeblocks  ./deploy/helm -f values.yaml --create-namespace

and the values.yaml file contains following values:

replicaCount: 3
image:
  tag: 0.8.3-beta.19
extraLables:
  app.kubernetes.io/component: "kubeblocks"
tolerations:
- key: kb-controller
  operator: Equal
  value: "true"
  effect: NoSchedule
affinity:
  nodeAffinity:
    preferredDuringSchedulingIgnoredDuringExecution:
    - weight: 100
      preference:
        matchExpressions:
        - key: kb-controller
          operator: In
          values:
          - "true"
  podAntiAffinity:
    requiredDuringSchedulingIgnoredDuringExecution:
    - labelSelector:
        matchLabels:
          app.kubernetes.io/instance: kubeblocks
          app.kubernetes.io/component: "kubeblocks"
      topologyKey: kubernetes.io/hostname
dataProtection:
  image:
    tag: 0.8.3-beta.19
  affinity:
    nodeAffinity:
      preferredDuringSchedulingIgnoredDuringExecution:
      - weight: 100
        preference:
          matchExpressions:
          - key: kb-controller
            operator: In
            values:
            - "true"
    podAntiAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
      - labelSelector:
          matchLabels:
            app.kubernetes.io/instance: kubeblocks
            app.kubernetes.io/component: "dataprotection"
        topologyKey: kubernetes.io/hostname
  extraLables:
    app.kubernetes.io/component: "dataprotection"

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label May 15, 2024
@shanshanying shanshanying marked this pull request as draft May 15, 2024 05:24
@shanshanying shanshanying marked this pull request as ready for review May 15, 2024 05:28
@shanshanying shanshanying force-pushed the bugfix/add-extra-labels-to-deploy branch from 5cc76cb to f715d98 Compare May 15, 2024 05:29
@apecloud-bot apecloud-bot added the approved PR Approved Test label May 15, 2024
@shanshanying shanshanying merged commit bc09546 into main May 15, 2024
32 checks passed
@shanshanying shanshanying deleted the bugfix/add-extra-labels-to-deploy branch May 15, 2024 05:40
@shanshanying
Copy link
Contributor Author

/cherry-pick release-0.9

@github-actions github-actions bot added this to the Release 0.8.3 milestone May 15, 2024
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/9090582943

github-actions bot pushed a commit that referenced this pull request May 15, 2024
Co-authored-by: wusai80 <wusai80@gmail.com>
(cherry picked from commit bc09546)
shanshanying added a commit that referenced this pull request May 15, 2024
Co-authored-by: wusai80 <wusai80@gmail.com>
shanshanying added a commit that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] KB and Dataprotection pods share the same lables
5 participants