chore: remove webhooks of all crds #7573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7573 +/- ##
==========================================
- Coverage 66.02% 64.66% -1.36%
==========================================
Files 343 329 -14
Lines 42227 41486 -741
==========================================
- Hits 27880 26828 -1052
- Misses 11916 12314 +398
+ Partials 2431 2344 -87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leon-inf
force-pushed
the
support/remove-webhooks-of-definition-crds
branch
from
cbf16d1
to
2d61885
Compare
github-actions
bot
added
size/XXL
leon-inf
force-pushed
the
support/remove-webhooks-of-definition-crds
branch
from
2d61885
to
a7d7edd
Compare
leon-inf
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
Y-Rookie and
weicao
as code owners
leon-inf
force-pushed
the
support/remove-webhooks-of-definition-crds
branch
from
a7d7edd
to
6d5868f
Compare
leon-inf
changed the title
leon-inf
force-pushed
the
support/remove-webhooks-of-definition-crds
branch
from
6d5868f
to
853b32b
Compare
weicao
reviewed
Jun 20, 2024
weicao
reviewed
Jun 21, 2024
config/webhook/manifests.yaml
Outdated
| @@ -24,26 +24,6 @@ webhooks: | |||
| resources: | |||
There was a problem hiding this comment.
Why keeps /mutate-workloads-kubeblocks-io-v1alpha1-instanceset
There was a problem hiding this comment.
All cleaned up.
This file is maintained and updated by controller-gen, it seems that it behaves weirdly when the webhook marker is removed.
leon-inf
force-pushed
the
support/remove-webhooks-of-definition-crds
branch
2 times, most recently
from
c99ed4d
to
bacfd4a
Compare
weicao
reviewed
Jun 21, 2024
| return errors.New("invalid destination object") | ||
| } | ||
| return convertToImpl(cc, ccv1) | ||
| return errors.New("not implemented") |
There was a problem hiding this comment.
Why keeps this two "ConverTo" methods?
leon-inf
force-pushed
the
support/remove-webhooks-of-definition-crds
branch
from
bacfd4a
to
3844eb6
Compare
weicao
approved these changes
Jun 21, 2024
Y-Rookie
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.