Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial YAML issue template for adding new database entry for a sensor #33

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Aug 15, 2022

@weiji14 weiji14 added the enhancement New feature or request label Aug 15, 2022
@weiji14 weiji14 self-assigned this Aug 15, 2022
@AdrienWehrle
Copy link
Contributor

Awesome, thanks a lot for working on this! So if I understand correctly, this is a GUI that's filling in a YAML? And this is through an issue, but how is it linked to a potential PR then? Is that the part that we still have to develop? A bot that would create a PR based on a template-generated issue?

@weiji14
Copy link
Member Author

weiji14 commented Aug 15, 2022

Awesome, thanks a lot for working on this! So if I understand correctly, this is a GUI that's filling in a YAML?

Yes, it's essentially just a structured form. This is actually designed for filling up bug reports/feature requests so the output isn't actually a YAML but there will be a GitHub issue opened as a result. From that issue, we will then need to parse the outputs (which is already structured) into a proper Pull Request.

And this is through an issue, but how is it linked to a potential PR then? Is that the part that we still have to develop? A bot that would create a PR based on a template-generated issue?

Yep, so there are a few ways/steps to link an issue to a PR, which can be automated by a bot. Just some ideas:

  1. Response directly. Have a welcome bot that reads the issue, and generates a proper YAML that users can then copy and paste to open a Pull Request.
  2. Only repond on trigger. Wait for a maintainer to respond via a comment or a label, the next event is triggered via a bot like https://github.com/peter-evans/slash-command-dispatch, or some other method.

Either way, we could pretty much just guide the user on what to do next, e.g. provide a link to https://github.com/APECS-Earth-Observation/Polar-EO-Database/new/main/data, maybe pre-fill all the data they've already filled in from the YAML, and then it's close enough to a PR, What do you think?

@AdrienWehrle
Copy link
Contributor

Super nice, I love it! Having a welcome bot sounds like a good idea and fun to setup! Since, as you say it, this is already structure, it shouldn't be too hard! :)

Copy link
Contributor

@AdrienWehrle AdrienWehrle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice, thanks a lot for working on this!

@AdrienWehrle AdrienWehrle marked this pull request as ready for review August 15, 2022 19:08
@AdrienWehrle AdrienWehrle merged commit 74a90dd into main Aug 15, 2022
@AdrienWehrle AdrienWehrle deleted the issue-yaml-form branch August 15, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants