Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class conflicts #12

Open
adrianbj opened this issue Mar 27, 2015 · 3 comments
Open

Class conflicts #12

adrianbj opened this issue Mar 27, 2015 · 3 comments

Comments

@adrianbj
Copy link

I just had a conflict with .edit but I am sure there will be others, so it would be great to prefix all classes with "ab_" or "adminbar_", or similar.

@apeisa
Copy link
Owner

apeisa commented Mar 27, 2015

I don't actually use AdminBar myself on any actively developed sites (now just simple admin link + fredi). Happy to merge any pull requests or add you or @teppokoivula as contributers?

@adrianbj
Copy link
Author

Thanks @apeisa - I posted about some of my recent tweaks over here: #11 (comment)

I'll aim to get things cleaned up for a PR at some point.

@teppokoivula
Copy link
Contributor

Just for the record, this should no longer be an issue in 2.x branch of the module (available from https://github.com/teppokoivula/adminbar). In the new version classes use BEM approach, so it should be very hard to run into conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants