Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File permissions #20

Closed
apeisa opened this issue Jan 31, 2014 · 4 comments
Closed

File permissions #20

apeisa opened this issue Jan 31, 2014 · 4 comments
Labels
discussion

Comments

@apeisa
Copy link
Owner

apeisa commented Jan 31, 2014

I have not yet played that much with file permissions in PW. It's clear that we need to figure those out too before release. Have you investigated this yet?
@niklaka
Copy link
Collaborator

niklaka commented Jan 31, 2014

At least I haven't. You're talking about secured pagefiles, right?

@apeisa
Copy link
Owner Author

apeisa commented Jan 31, 2014

Yep.
31.1.2014 15.27 kirjoitti "Niklas Lakanen" notifications@github.com:

At least I haven't. You're talking about secured pagefiles, right?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-33793512
.

@niklaka
Copy link
Collaborator

niklaka commented Feb 3, 2014

This one's actually almost trivial! We just need another hook (Page::isPublic() - will request that from Ryan) and a few lines of code. Got it covered locally, will commit tomorrow with a bunch of other things.

@apeisa
Copy link
Owner Author

apeisa commented Feb 3, 2014

Great news!

niklaka referenced this issue Feb 4, 2014
@niklaka
Added isPublic() hook for secure pagefiles to work. Added more checks…
b553acb 
… to see if template based access control should be used instead.
@niklaka niklaka closed this as completed Feb 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apeisa @niklaka