Release 1.6.2 to master #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 1.6.1 to dev
- Add extra job statuses that Slurm parser accepts as they represent jobs that will still have used resrouces. - Add matching tests for all possible job statuses.
- Add NODE_FAIL to accepted Slurm statuses as it is also a "terminated" status. - Update tests and add comments and error messages to them.
- Remove negative wallduration check from SLRUM parser as parse_time function prevents that from happening. - Update tests to match.
Extra SLURM statuses
Correct files that have CRLF line endings to LF
Remove references to specific LSF versions as that restriction has been removed from the code a while ago (but the docs weren't updated).
Remove references to specific LSF versions
- the test captures what happens as of 1.6.1 and helps convince us we aren't breaking anything when making any future chnages to default CloudRecord values.
- Helps convince us we aren't breaking anything when making any future changes to default CloudRecord values
- when it is ommited, NULL is written as the CpuCount in the CloudRecord table, which causes problems at summariser time as NULL CpuCounts aren't allowed in the CloudSummaries table
- Cleans up any existing cloud data with a NULL CpuCount, which causes warnings when we try and insert cloud summarises with NULL CpuCounts into the cloud summary table
Fix summariser CpuCount warnings for cloud accounting
Simplify update script inclusion in SPEC file by matching on wildcard. This will help avoid ommitting files in future (as was almost the case here where the 1.6.2 script was missing from the file section).
|
oooooh GitHub seems to be aware I have reviewed these changes in #158, neat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming #158 has been reviewed, this shouldn't contain any unreviewed code - everything should have been covered in PRs against the
devbranch.