Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings in log if no records unloaded #180

Merged
merged 2 commits into from Dec 7, 2018

Conversation

tofu-rocketry
Copy link
Member

We often get people raising tickets when they realise their accounting data isn't displaying and it turns out to be a publishing issue. Sometimes they've not checked their log, and other times they just haven't spotted any problems in the log.

This PR addresses the second case by adding warnings in log if no usage or sync records are unloaded to hopefully make it clearer when something has not gone right.

Add warnings in log if no usage or sync records are unloaded to
hopefully make it clearer when something has not gone right.
@tofu-rocketry tofu-rocketry added this to the 1.8.0 milestone Dec 5, 2018
@tofu-rocketry tofu-rocketry self-assigned this Dec 5, 2018
jrha
jrha previously approved these changes Dec 6, 2018
Copy link
Contributor

@jrha jrha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is it always an issue if no records were unloaded?

@tofu-rocketry
Copy link
Member Author

It would usually be an issue. If they're sending job records, they would have to have had no jobs finished since the last run of the APEL client, but there would still be sync records. If they're sending summary records, then that would be a problem as they should be sending updated summaries for the last two months on each run of the client.

I guess I could make it more conservative and only warn if there were no sync records, or modify the message for the first case to just prompt the user to check that there were no new jobs run.

@jrha
Copy link
Contributor

jrha commented Dec 7, 2018

Or just change the message a bit? You don't want to exchange one form of spurious ticket for another.

Perhaps:
"No sync records unloaded. If this is unexpected, please check your config."

@tofu-rocketry
Copy link
Member Author

There we go. I've also clarified what general type of records are meant in the first warning message.

@tofu-rocketry tofu-rocketry merged commit e111a26 into apel:dev Dec 7, 2018
@tofu-rocketry tofu-rocketry deleted the extra-client-warnings branch December 7, 2018 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants