Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of output lines of more than 64k #98

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Fix parsing of output lines of more than 64k #98

merged 1 commit into from
Jun 13, 2022

Conversation

asafalima
Copy link
Contributor

Also in this PR:

  • Propagating errors during output parsing
  • Enable JSON parsing tests

@asafalima
Copy link
Contributor Author

@apenella Can you please take a look at the PR?

@apenella
Copy link
Owner

apenella commented Jun 7, 2022

Hi @asafalima
Thank you very much for your PR, I am going to review it during next few days. To do the review I will merge it into a temporal branch where I will update release notes, changelog, etc. and finally it will be merged to master branch. My idea is to keep it on master branch and release it with v1.2.0.

I keep you updated!

@apenella apenella added the fix label Jun 7, 2022
@apenella apenella changed the base branch from master to fix-parsing-of-long-lines-in-output June 7, 2022 05:53
@apenella apenella merged commit 0982e8c into apenella:fix-parsing-of-long-lines-in-output Jun 13, 2022
@apenella apenella mentioned this pull request Jun 13, 2022
Merged
@apenella
Copy link
Owner

@asafalima just to let you know, I decided to prepare the release v1.1.6 which will have your changes.
Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix v1.1.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asafalima @apenella