Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement to state.files() on simple branch #10

Closed
wants to merge 1 commit into from

Conversation

jasom
Copy link

@jasom jasom commented May 16, 2012

In a slightly-odd real-world case this sped up redo-targets by an order of magnitude (if you are curious it was a generated website with lots and lots of directories like 2001/11/05/title/index.html)

We were processing <target>.deps.redo files even when we knew we had
already seen <target>; if we've already seen target, then we've already
processed <target>.deps.redo.
@apenwarr
Copy link
Owner

Hi,

Please send patches to the redo-list mailing list so they don't get
lost. You don't have to subscribe to the mailing list in order to
send patches.

Thanks,

Avery

On Wed, May 16, 2012 at 2:55 PM, Jason Miller
reply@reply.github.com
wrote:

In a slightly-odd real-world case this sped up redo-targets by an order of magnitude (if you are curious it was a generated website with lots and lots of directories like 2001/11/05/title/index.html)

You can merge this Pull Request by running:

 git pull https://github.com/jasom/redo simple

Or you can view, comment on it, or merge it online at:

 #10

-- Commit Summary --

  • Don't needlessly recurse into dependencies

-- File Changes --

M state.py (8)

-- Patch Links --

 https://github.com/apenwarr/redo/pull/10.patch
 https://github.com/apenwarr/redo/pull/10.diff


Reply to this email directly or view it on GitHub:
#10

@apenwarr
Copy link
Owner

The simple branch is a dead end. I'm going to try to fix the state features using a different method.

@apenwarr apenwarr closed this Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants