Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response status of invalid ticket #80

Open
psfung opened this issue Jun 3, 2013 · 2 comments
Open

response status of invalid ticket #80

psfung opened this issue Jun 3, 2013 · 2 comments
Milestone

Comments

@psfung
Copy link

psfung commented Jun 3, 2013

For a request with an invalid ticket, PHP CAS prints an error message, but the response status is still 200. In this case, 403 is more appropriate.

@jfritschi
Copy link
Contributor

Since phpCAS is mostly integrated behind the scenes in other application frameworks it does not make sense to modify the server status code per default. This should be left to the integrator since we cannot simply throw a 403 in a users face is something in the library reports an error.

If you have some clever suggestion on how to adress it that everyone is happy I'm all ears. We should probably allow for some error handler hook so that an integrator can chose/extend the error handling themselves. This however would be a major change.

@psfung
Copy link
Author

psfung commented Jul 25, 2013

Currently the error message of invalid ticket is returned in html body directly by phpCAS. It is not absolutely behind the scene. Error handler hook is the best solution. If not available, I think it is acceptable to return some sensible default message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants