Skip to content

Commit

Permalink
Tested and fixed closed categories
Browse files Browse the repository at this point in the history
  • Loading branch information
gourab337 committed Jun 17, 2021
1 parent b419f2d commit e6647f9
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions apertium-ben-hin.ben-hin.dix
Expand Up @@ -430,7 +430,7 @@

<!-- negation markers are missing in bengali-->


<e><p><l>বিল্ডিং<s n="n" /><s n="nt" /><s n="nn" /><s n="sg" /><s n="nom" /></l><r>इमारतें<s n="n"/><s n="m"/><s n="sg"/><s n="nom"/></r></p></e>
<e><p><l>ভারত<s n="np" /><s n="top" /><s n="mf" /><s n="sg" /><s n="nom" /></l><r>भारत<s n="np"/><s n="top"/><s n="sg"/></r></p></e>

This comment has been minimized.

Copy link
@hectoralos

hectoralos Jun 17, 2021

Member

Really <s n="sg"/><s n="nom"/> need to be specified? What about forms in plural and/or non-nominative cases?

This comment has been minimized.

Copy link
@hectoralos

hectoralos Jun 17, 2021

Member

And the same for <s n="nom" /> in the top.

This comment has been minimized.

Copy link
@gourab337

gourab337 Jun 17, 2021

Author Collaborator

In context of number, it will be same (pl=sg)...

This comment has been minimized.

Copy link
@hectoralos

hectoralos Jun 18, 2021

Member

The problem is that, if you specify n=sg (and/or n=nom), any analysis where you'll get n=pl won't match to anything in the bidix, so it will be an unknown word (form). Specifications in the bilingual dictionary must be enough, but not too precise.

This comment has been minimized.

Copy link
@gourab337

gourab337 Jun 18, 2021

Author Collaborator

ohhh okay. Makes sense. Changing it and similar cases.

<e><p><l>মালিক<s n="n"/><s n="mf"/><s n="hu"/></l><r>मालिक<s n="n"/><s n="m"/></r></p></e>
<e><p><l>শিক্ষক<s n="n"/><s n="mf"/><s n="hu"/></l><r>शिक्षक<s n="n"/><s n="m"/></r></p></e>
Expand Down Expand Up @@ -494,6 +494,7 @@
<e><p><l>ট্রাক<s n="n"/><s n="mf"/><s n="nn"/></l><r>ट्रक<s n="n"/><s n="m"/></r></p></e>
<e><p><l>টাকা<s n="n"/><s n="mf"/><s n="nn"/></l><r>पैसा<s n="n"/><s n="m"/></r></p></e>
<e><p><l>কথা<s n="n"/><s n="mf"/><s n="nn"/></l><r>बात<s n="n"/><s n="m"/></r></p></e>
<e><p><l>ছাত্র<s n="n"/><s n="mf"/><s n="hu"/><s n="sg"/><s n="nom"/></l><r>छात्र<s n="n"/><s n="m"/><s n="sg"/><s n="nom"/></r></p></e>

This comment has been minimized.

Copy link
@hectoralos

hectoralos Jun 17, 2021

Member

Really <s n="sg"/><s n="nom"/> need to be specified? What about forms in plural and/or non-nominative cases?

<!--Numerals--> <!-- GSoC 2021 -->

Expand Down Expand Up @@ -541,7 +542,7 @@
<e r="LR"><p><l>চার<s n="num"/><s n="hu"/></l><r>चार<s n="num"/></r></p></e>
<e r="LR"><p><l>চার<s n="num"/><s n="el"/></l><r>चार<s n="num"/></r></p></e>

<e><p><l>দু<s n="num"/><s n="an"/></l><r>दो<s n="num"/></r></p></e>
<e><p><l>দুই<s n="num"/><s n="an"/></l><r>दो<s n="num"/></r></p></e>
<e r="LR"><p><l>দু<s n="num"/><s n="nn"/></l><r>दो<s n="num"/></r></p></e>
<e r="LR"><p><l>দু<s n="num"/><s n="aa"/></l><r>दो<s n="num"/></r></p></e>
<e r="LR"><p><l>দু<s n="num"/><s n="hu"/></l><r>दो<s n="num"/></r></p></e>

This comment has been minimized.

Copy link
@hectoralos

hectoralos Jun 17, 2021

Member

Are you sure this is the best solution? This way you will never be able to generate "nn", "aa", "hu". Better not to forbid this possibility in the dictionary.

This comment has been minimized.

Copy link
@gourab337

gourab337 Jun 17, 2021

Author Collaborator

দু doesn't even make sanse (for any of those cases too). দুই can be used to describe "2" for "nn" / "aa" / "hu", etc So simplified it here

This comment has been minimized.

Copy link
@hectoralos

hectoralos Jun 18, 2021

Member

OK, so )

Expand Down Expand Up @@ -957,6 +958,7 @@
<e><p><l>কাছে<s n="post"/></l><r>पास में<s n="post"/></r></p></e>
<e><p><l>কারনে<s n="post"/></l><r>चूंकि<s n="post"/></r></p></e>
<e><p><l>সোজা<s n="post"/></l><r>सीधे<s n="post"/></r></p></e>
<!--Check this case-->
<e><p><l>সত্ত্বেও<s n="post"/></l><r>के बावजूद<s n="post"/></r></p></e>

This comment has been minimized.

Copy link
@hectoralos

hectoralos Jun 17, 2021

Member

I recommend you to put this kind of comments in the same line. Lines are often sorted in dixs. You'll lose which case you had to check.

This comment has been minimized.

Copy link
@gourab337

gourab337 Jun 17, 2021

Author Collaborator

Ohh okay thanks.. will do.

<e><p><l>বিরুদ্ধে<s n="post"/></l><r>विरुद्ध<s n="post"/></r></p></e>
<e><p><l>দূরে<s n="post"/></l><r>दूर<s n="post"/></r></p></e>
Expand Down

0 comments on commit e6647f9

Please sign in to comment.