Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/scatter chart #136

Merged
merged 3 commits into from Jul 2, 2017
Merged

Feature/scatter chart #136

merged 3 commits into from Jul 2, 2017

Conversation

apertureless
Copy link
Owner

@apertureless apertureless commented Jul 2, 2017

Add Scatter Chart

Implement #129

New Chart type added (Scatter), which is actually only syntactic sugar for the line chart with x/y data points.

You can now easy create a scatter chart with:

import {Scatter} from 'vue-chartjs'

export default Scatter.extend({})

⚠ Important note

As the structure of the passed data is quite different from the other charts, neither the reactiveProp nor reactiveData mixins will work with it.

It will require some refactoring and additions to the mixins to work with it.

@codecov
Copy link

codecov bot commented Jul 2, 2017

Codecov Report

Merging #136 into develop will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           develop   #136   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           10     11    +1     
  Lines           86     95    +9     
======================================
+ Hits            86     95    +9
Impacted Files Coverage Δ
src/BaseCharts/Scatter.js 100% <100%> (ø)

@apertureless apertureless merged commit 0a48394 into develop Jul 2, 2017
@apertureless apertureless mentioned this pull request Jul 2, 2017
@apertureless apertureless added this to the 2.7.0 milestone Jul 4, 2017
@apertureless apertureless deleted the feature/scatter_chart branch July 4, 2017 08:47
@nstCactus
Copy link

I think you may be missing an export in the index.js file. Using version 2.7.0, it seems to be still missing and so:

import { Scatter } from "vue-chartjs";
console.log(Scatter); // Logs undefined

If you wish I can prepare a PR to fix it.

@apertureless
Copy link
Owner Author

Ups! Thanks for that one.
Fixed in 2.7.1 🙈

@nstCactus
Copy link

That was quick, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants