Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events): Add events to reactiveMixins #389

Merged
merged 3 commits into from
Aug 4, 2018
Merged

Conversation

apertureless
Copy link
Owner

@apertureless apertureless commented Jul 16, 2018

This will resolve #382


Added some vue events to the mixins based on different actions.

  • chart:render - if the mixin performs a complete rerender
  • chart:destroy - if the mixin deletes the chart object instance
  • chart:update - if the mixin performs an update instead of a re-render
  • labels:update - if new labels were set
  • xlabels:update if new xLabels were set
  • ylabels:update - if new yLabels were set

todo

  • update docs
  • update tests

@apertureless apertureless self-assigned this Jul 16, 2018
@apertureless apertureless added this to the 2.4.0 milestone Jul 16, 2018
@apertureless apertureless merged commit 67e8e4d into develop Aug 4, 2018
apertureless added a commit that referenced this pull request Aug 4, 2018
* develop:
  chore(release): Add dist files
  chore(release): 3.4.0
  feat(events): Add events to reactiveMixins (#389)
  feat(ux): Add a wrapper around generateLegend (#390)
  feat(ux): Add fake render method with error message
  chore(docs): Update README
  feat(typescript): Add basic typescript definitions
@apertureless apertureless deleted the feature/events branch October 20, 2018 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Emit events from mixins with essential info
1 participant