Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate HorizontalBar component added #56

Merged

Conversation

imbashamba
Copy link
Contributor

To remove optional 'type' parameter at Bar component, which was ignored inside reactive mixins.
It was resulting in horizontal bars becoming vertical after dataset reactive change

Fix or Enhancement?

Fix

  • [* ] All tests passed

Environment

  • OS: Windows 10 x64
  • NPM Version: 3.10.10

…ameter at Bar, which was ignored inside reactive mixins
@codecov
Copy link

codecov bot commented Mar 7, 2017

Codecov Report

Merging #56 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #56   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9     10    +1     
  Lines          75     85   +10     
=====================================
+ Hits           75     85   +10
Impacted Files Coverage Δ
src/BaseCharts/Bar.js 100% <ø> (ø)
src/BaseCharts/HorizontalBar.js 100% <100%> (ø)
src/index.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb567e...fcaa3de. Read the comment docs.

@apertureless apertureless changed the base branch from master to develop March 7, 2017 19:30
@apertureless apertureless self-requested a review March 7, 2017 19:31
@apertureless apertureless merged commit 9bd7712 into apertureless:develop Mar 7, 2017
@apertureless
Copy link
Owner

Thanks for the PR! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants