Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger body fix #36

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Trigger body fix #36

merged 5 commits into from
Mar 28, 2024

Conversation

nawforce
Copy link
Contributor

No description provided.

@nawforce nawforce linked an issue Dec 24, 2023 that may be closed by this pull request
Copy link
Contributor

@pwrightcertinia pwrightcertinia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spotted 1 issue

jvm/src/main/java/com/nawforce/apexparser/Check.java Outdated Show resolved Hide resolved
npm/src/__tests__/ApexTriggerTest.ts Show resolved Hide resolved
npm/src/index.ts Outdated Show resolved Hide resolved
## 3.6.0 - 2024-02-15

- Add null coalesce operator and expression

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird this is showing as a change, merge being funny

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looking OK now

const classErrors = parseByType(path, files, ".cls", (parser: ApexParser) => {parser.compilationUnit();});
const triggerErrors = parseByType(path, files, ".trigger", (parser: ApexParser) => {parser.triggerUnit();});
return classErrors.concat(triggerErrors)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better than what I came up with

@nawforce nawforce merged commit 987fb2e into main Mar 28, 2024
1 check passed
@nawforce nawforce deleted the 35-merge-open-source-improvements branch March 28, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge open source improvements
2 participants