switched to apex-enterprise-patterns/setup-sfdx@v2

[ImJohnMDaniel]

This change is 

[daveespo]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ImJohnMDaniel and @stohn777)

---

.github/workflows/deploy.and.test.yml line 26 at r1 (raw file):

      # Setup the config parameters needed
      - run: sf config set target-dev-hub SFDX-ENV --global #Even though the setup-sfdx action uses --setdefaultdevhubusername, it doesn't seem to stick since it uses --setdefaultusername so we brute force it here
      # Create the scratch org

What's the reasoning with these rather uninformative comments in the YAML? Comments should only be used for unidiomatic code .. there's no mystery here as to what's going on

If you want to add the name property so that the log output in the GH UI is more palatable, that makes more sense ..

[ImJohnMDaniel]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ImJohnMDaniel and @stohn777)

.github/workflows/deploy.and.test.yml line 26 at r1 (raw file):

      # Setup the config parameters needed
      - run: sf config set target-dev-hub SFDX-ENV --global #Even though the setup-sfdx action uses --setdefaultdevhubusername, it doesn't seem to stick since it uses --setdefaultusername so we brute force it here
      # Create the scratch org

What's the reasoning with these rather uninformative comments in the YAML? Comments should only be used for unidiomatic code .. there's no mystery here as to what's going on

If you want to add the name property so that the log output in the GH UI is more palatable, that makes more sense ..

@daveespo, in my opinion, the comments help with the readability; nothing more.

[daveespo]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ImJohnMDaniel)