Enable gateway to work with Application Load Balancer with Multi Value Headers enabled #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests have failed due to output being changed slightly, but it looks like that when multi value headers are not being used the contents should be ignored. |
|
I'd like to add a +1 to this PR, we are facing the same issue and it is causing this version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been using gateway with go-gin and recently swapped from using an API Gateway to an ALB for routing, which worked fine. However, when trying to turn multi value headers on the site broke when run through gateway.
I have discovered that the multi value headers were being set with lower case header names, which was not being picked up using Header.Get, and that the ALB expects all header values to be returned in the multi value headers when using this mode.
My testing suggests that this should not break anything when running without multi value headers enabled as before.