Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore file support #33

Closed
3 tasks
tj opened this issue Jul 4, 2017 · 5 comments
Closed
3 tasks

Ignore file support #33

tj opened this issue Jul 4, 2017 · 5 comments

Comments

@tj
Copy link
Member

tj commented Jul 4, 2017

There will of course be .upignore support, but I'd love some feedback on default behaviour:






  • add filter support
  • add .gitignore if present
  • add .npmignore if present
@tj tj added this to the 1.0.0-alpha milestone Jul 4, 2017
@tj tj closed this as completed Jul 11, 2017
@hhsnopek
Copy link
Contributor

Will .upignore allow inverse/negative-patterns and override previously defined patterns if other ignores files, like dotfiles/.gitignore, are allowed/used?

@tj
Copy link
Member Author

tj commented Jul 11, 2017

@hhsnopek yep! For now I'm going to ignore dotfiles by default, and combine .gitignore/.npmignore/.upignore (in that order), but ! is supported

@tj
Copy link
Member Author

tj commented Jul 19, 2017

pretty unintuitive when .gitignore usually has node_modules, guess we'll have to inject that in all hacky like :'(

@hhsnopek
Copy link
Contributor

if up has a "starter-kit" for node, add it to the .upignore, and add a note in the docs 🙃

@tj
Copy link
Member Author

tj commented Jul 19, 2017

injecting it in there for now :D haha, can still override via .upignore if anyone is using webpack etc, kinda hacky but definitely what I'd expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants