stacked line charts regression - fix #4132

apexcharts · Dec 5, 2023 · 774c7f6 · 774c7f6
1 parent 630f9cb
commit 774c7f6
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 16 deletions.
diff --git a/src/charts/Line.js b/src/charts/Line.js
@@ -511,9 +511,11 @@ class Line {
     let y2 = y
 
     let stackSeries =
-      w.config.chart.stacked &&
-      (!this.w.config.chart.stackOnlyBar ||
-        this.w.config.series[realIndex]?.type === 'bar')
+      (w.config.chart.stacked && !w.globals.comboCharts) ||
+      (w.config.chart.stacked &&
+        w.globals.comboCharts &&
+        (!this.w.config.chart.stackOnlyBar ||
+          this.w.config.series[realIndex]?.type === 'bar'))
 
     for (let j = 0; j < iterations; j++) {
       const isNull =

diff --git a/src/charts/common/line/Helpers.js b/src/charts/common/line/Helpers.js
@@ -105,8 +105,11 @@ export default class Helpers {
   determineFirstPrevY({ i, series, prevY, lineYPosition }) {
     let w = this.w
     let stackSeries =
-      w.config.chart.stacked &&
-      (!w.config.chart.stackOnlyBar || series?.[i]?.type === 'bar')
+      (w.config.chart.stacked && !w.globals.comboCharts) ||
+      (w.config.chart.stacked &&
+        w.globals.comboCharts &&
+        (!this.w.config.chart.stackOnlyBar ||
+          this.w.config.series[i]?.type === 'bar'))
 
     if (typeof series[i]?.[0] !== 'undefined') {
       if (stackSeries) {

diff --git a/src/modules/Data.js b/src/modules/Data.js
@@ -454,14 +454,7 @@ export default class Data {
         ser[i].type === 'rangeArea'
       ) {
         gl.isRangeData = true
-        if (gl.isComboCharts) {
-          if (ser[i].type === 'rangeBar' || ser[i].type === 'rangeArea') {
-            this.handleRangeData(ser, i)
-          }
-        } else if (
-          cnf.chart.type === 'rangeBar' ||
-          cnf.chart.type === 'rangeArea'
-        ) {
+        if (cnf.chart.type === 'rangeBar' || cnf.chart.type === 'rangeArea') {
           this.handleRangeData(ser, i)
         }
       }

diff --git a/src/modules/Range.js b/src/modules/Range.js
@@ -554,10 +554,13 @@ class Range {
             stackedPoss[group][j] = 0
             stackedNegs[group][j] = 0
           }
+
           let stackSeries =
-            !this.w.config.chart.stackOnlyBar ||
-            gl.series?.[i]?.type === 'bar' ||
-            this.w.config.chart.type === 'bar'
+            (this.w.config.chart.stacked && !gl.comboCharts) ||
+            (this.w.config.chart.stacked &&
+              gl.comboCharts &&
+              (!this.w.config.chart.stackOnlyBar ||
+                this.w.config.series?.[i]?.type === 'bar'))
 
           if (stackSeries) {
             if (gl.series[i][j] !== null && Utils.isNumber(gl.series[i][j])) {