Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve how to contribute #3951

Merged
merged 7 commits into from
Aug 27, 2023
Merged

docs: improve how to contribute #3951

merged 7 commits into from
Aug 27, 2023

Conversation

maciej-ka
Copy link
Contributor

@maciej-ka maciej-ka commented Aug 2, 2023 •
edited

Hi, it's my first contribution to this project, any suggestions are welcome.

  • add info about the samples directory and how to run it locally
  • describe how to work on fix or feature using npm link
  • update info on how to run tests (how to handle chromium not found)
  • how to handle failing e2e tests due to slight differences between OS/browser versions
  • link contributing.md in readme.md

@maciej-ka maciej-ka changed the title [WIP] docs: improve how to contribute docs: improve how to contribute Aug 6, 2023
@junedchhipa junedchhipa merged commit acca157 into apexcharts:main Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junedchhipa junedchhipa junedchhipa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maciej-ka @junedchhipa